Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DRb debug code #33

Merged
merged 2 commits into from
Mar 13, 2018
Merged

Conversation

agrare
Copy link
Member

@agrare agrare commented Feb 6, 2018

With the DRb connection issues resolved we can remove the extra checks which were added to help find the issue.

These were:

Depends:

This reverts commit 14731a6, reversing
changes made to 3299c80.
This reverts commit 2e03c3b, reversing
changes made to 34b2160.
@miq-bot
Copy link
Member

miq-bot commented Feb 6, 2018

Checked commits agrare/vmware_web_service@ea36eac~...c63984f with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@agrare agrare changed the title [WIP] Remove DRb debug code [Depends manageiq/pull/16953] Remove DRb debug code Feb 6, 2018
@agrare agrare removed the wip label Feb 6, 2018
@agrare
Copy link
Member Author

agrare commented Feb 6, 2018

cc @Fryguy

@Fryguy Fryguy merged commit c0ea9b5 into ManageIQ:master Mar 13, 2018
@agrare agrare deleted the remove_drb_debug_code branch March 13, 2018 17:26
@simaishi
Copy link

Fine backport (to manageiq-gems-pending) details:

$ git log -1
commit 24013eea31b69245453187bd392a0b7a10456008
Author: Jason Frey <fryguy9@gmail.com>
Date:   Tue Mar 13 13:26:03 2018 -0400

    Merge pull request #33 from agrare/remove_drb_debug_code
    
    Remove DRb debug code
    (cherry picked from commit c0ea9b58a118aef57878745ed9479e16d115b4a4)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1572719

@simaishi
Copy link

@miq-bot add_label fine/backported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants