Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the DRb::DRbServer.load_limit size from 50 to 100 MiB #38

Merged
merged 1 commit into from
May 2, 2018

Conversation

agrare
Copy link
Member

@agrare agrare commented May 1, 2018

Incrase the DRb::DRbServer.load_limit to 100MiB to handler larger vSphere inventories.

https://bugzilla.redhat.com/show_bug.cgi?id=1573588

@agrare agrare added the bug label May 1, 2018
@agrare agrare force-pushed the bz_1573588_drb_server_load_limit branch from c974d91 to 176f320 Compare May 1, 2018 19:47
@agrare
Copy link
Member Author

agrare commented May 1, 2018

@Fryguy I switched from using DRb::DRbServer.default_load_limit() to passing the load limit to start_service so we could use the worker setting set by https://github.com/ManageIQ/manageiq-providers-vmware/pull/245/files#diff-a651af8dd48c191490be1598bebf9a84R253

@agrare agrare changed the title Make DRb::DRbServer.load_limit configurable [WIP] Make DRb::DRbServer.load_limit configurable May 2, 2018
@agrare
Copy link
Member Author

agrare commented May 2, 2018

Setting it just in DRb.start_service doesn't seem to be enough, going to back to setting it at the class level for now even if it won't be configurable.

@agrare agrare force-pushed the bz_1573588_drb_server_load_limit branch from 176f320 to 114b0f3 Compare May 2, 2018 00:36
@miq-bot miq-bot added the wip label May 2, 2018
@agrare agrare changed the title [WIP] Make DRb::DRbServer.load_limit configurable Make DRb::DRbServer.load_limit configurable May 2, 2018
@agrare agrare removed the wip label May 2, 2018
@agrare agrare force-pushed the bz_1573588_drb_server_load_limit branch from 114b0f3 to dac9e4e Compare May 2, 2018 13:20
@JPrause
Copy link
Member

JPrause commented May 2, 2018

@miq-bot add_label blocker

@miq-bot
Copy link
Member

miq-bot commented May 2, 2018

@JPrause Cannot apply the following label because they are not recognized: blocker

@JPrause
Copy link
Member

JPrause commented May 2, 2018

@agrare if this PR can be backported, can you add the gaprindashvili/yes label.

Increase the DRb::DRbServer.load_limit size to handle larger vmware
inventories.

https://bugzilla.redhat.com/show_bug.cgi?id=1573588
@agrare agrare force-pushed the bz_1573588_drb_server_load_limit branch from dac9e4e to fd469e8 Compare May 2, 2018 15:19
@agrare agrare changed the title Make DRb::DRbServer.load_limit configurable Increase the DRb::DRbServer.load_limit size from 50 to 100 MiB May 2, 2018
@Fryguy
Copy link
Member

Fryguy commented May 2, 2018

@JPrause This is a gem, not a plugin...there is no backport, only release

@miq-bot
Copy link
Member

miq-bot commented May 2, 2018

Checked commit agrare@fd469e8 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@agrare
Copy link
Member Author

agrare commented May 2, 2018

@JPrause the only backport we'll need to do is to fine because the broker was still in manageiq-gems-pending back then. I'll add fine/yes after it is merged.

@JPrause
Copy link
Member

JPrause commented May 2, 2018

@Fryguy my bad,..thanks for the explanation.

@Fryguy Fryguy merged commit b8d8c9e into ManageIQ:master May 2, 2018
@agrare agrare deleted the bz_1573588_drb_server_load_limit branch May 2, 2018 16:00
@agrare agrare added the fine/yes label May 2, 2018
@simaishi
Copy link

simaishi commented May 2, 2018

Fine backport (to manageiq-gems-pending repo) details:

$ git log -1
commit 4484d0c66ce54c566090575b3802a048635ba97d
Author: Jason Frey <fryguy9@gmail.com>
Date:   Wed May 2 12:00:34 2018 -0400

    Merge pull request #38 from agrare/bz_1573588_drb_server_load_limit
    
    Increase the DRb::DRbServer.load_limit size from 50 to 100 MiB
    (cherry picked from commit b8d8c9e0e1098b30fefe99d39373acdf1683dce3)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1574155

@simaishi
Copy link

simaishi commented May 2, 2018

@miq-bot add_label fine/backported
@miq-bot remove_label fine/yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants