Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bored command weights #391

Open
Ixrec opened this issue May 12, 2023 · 3 comments
Open

bored command weights #391

Ixrec opened this issue May 12, 2023 · 3 comments
Assignees
Labels
feature New feature. Use severity level labels (level: <level>) to show the severity. severity: minor Not blocking features and not disruptive, can be considered "Quality Of Life" change. size: small Should take a day or less to implement.

Comments

@Ixrec
Copy link
Contributor

Ixrec commented May 12, 2023

We've often wanted to tweak how likely a certain bored command is to get randomly chosen, but we don't have an exact design in mind for this yet.

The only prep I've personally done for this was thinking about it during #62 enough to convince myself that BoredCommands being a flat list of strings is fine because we'd probably want to store the weights as a separate config item.

@Ixrec Ixrec added feature New feature. Use severity level labels (level: <level>) to show the severity. severity: minor Not blocking features and not disruptive, can be considered "Quality Of Life" change. size: small Should take a day or less to implement. labels May 12, 2023
@MercurialPony MercurialPony self-assigned this May 12, 2023
@MercurialPony
Copy link
Contributor

Potential idea for an implementation of this feature:

Each bored command will have an associated integer weight, could be 1 by default in case the user doesn't want to bother with it. The chance to run each bored command would be command_weight / total_command_weight so commands with a higher weight have a higher chance to run

This would keep things pretty simple for the end user allowing them to either not specify anything and just go with the default value or have to input only an extra integer

@Ixrec
Copy link
Contributor Author

Ixrec commented Nov 19, 2023

Oops. I was not talking about the complexity of implementing weights after they've been configured (which I agree is not that hard), I'm worried about the "UI" complexity of how a moderator edits bored commands and weights.

@MercurialPony
Copy link
Contributor

I was partially taking UI into consideration in my suggestion

Looking at the code, one possibility would be to introduce a new ConfigItemType which would simply have an extra integer weight. The user could (optionally) specify the weight as the first argument so that both arguments could easily be distinguished

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature. Use severity level labels (level: <level>) to show the severity. severity: minor Not blocking features and not disruptive, can be considered "Quality Of Life" change. size: small Should take a day or less to implement.
Projects
None yet
Development

No branches or pull requests

2 participants