Rails 6 support

[jeremy]

No description provided.

[codecov-io]

Codecov Report

Merging #84 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files          16       16           
  Lines         496      496           
=======================================
  Hits          488      488           
  Misses          8        8

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c651b5c...3add0b0. Read the comment docs.

[Fudoshiki]

Any plans merge it?

[Mange]

Can you see if you can get the coverage information to ignore all vendored code?

[Fudoshiki]

Hello, what's block this PR?

[Mange]

What's the block

Life. I'll get to it eventually. Feel free to use this fork for the moment.

Is Rails 6 out?

[Mange]

So I see that this is for "Rails master". I won't have time to follow Rails master since this gem is now under passive maintenance so I will close this PR.

Please open a new PR when Rails 6 is out (beta or RC is also fine).

I still want to thank you for your time. I am sorry for letting you down. 😞

[jeremy]

I won't have time to follow Rails master since this gem is now under passive maintenance so I will close this PR.

I understand. However, I think this PR will help you with passive maintenance. By tracking the "next" Rails release, Roadie contributors can take over significant maintenance responsibility, guided by CI against their pull requests. Help us help you 😊

[Mange]

I don't understand how. You still need to generate a new app on every release or that version isn't tracked, and Rails changes their defaults/configs/code generation occasionally so this generated app could get more and more out of date, giving us less and less confidence over time.

I'm probably just missing something. I cannot reopen since the underlying branch was force pushed, but you could open a new PR and it can be discussed in that PR if you want.

[jeremy]

You're absolutely right that it's not maintenance-free! Just a way to help shift some of the responsibility for forward compatibility to PR authors.