Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No subcaption if save_last_frame is True #69

Merged
merged 5 commits into from
Sep 13, 2023
Merged

No subcaption if save_last_frame is True #69

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eab8181
Initialize input_device_index when opening pyaudio stream
mkuehne-git Aug 2, 2023
5aa0b6d
Fix initialization of rate and channels.
mkuehne-git Aug 5, 2023
7fdd6e1
Merge branch 'ManimCommunity:main' into main
mkuehne-git Sep 4, 2023
5074815
Fix: No subcaptions if save_lastframe is True
mkuehne-git Sep 4, 2023
bef4b7b
Merge branch 'main' of https://github.com/mkuehne-git/manim-voiceover
mkuehne-git Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions manim_voiceover/voiceover_scene.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,15 @@ def set_speech_service(

Args:
speech_service (SpeechService): The speech service to be used.
create_subcaption (bool, optional): Whether to create subcaptions for the scene. Defaults to True.
create_subcaption (bool, optional): Whether to create subcaptions for the scene. Defaults to True. If `config.save_last_frame` is True, the argument is
ignored and no subcaptions will be created.
"""
self.speech_service = speech_service
self.current_tracker = None
self.create_subcaption = create_subcaption
if config.save_last_frame:
self.create_subcaption = False
else:
self.create_subcaption = create_subcaption

def add_voiceover_text(
self,
Expand Down