Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting back to CI #3622

Open
Viicos opened this issue Feb 16, 2024 · 2 comments
Open

Add linting back to CI #3622

Viicos opened this issue Feb 16, 2024 · 2 comments
Labels
good first issue Good for newcomers help wanted We would appreciate help on this issue/PR tracking
Milestone

Comments

@Viicos
Copy link
Member

Viicos commented Feb 16, 2024

Following #3620, would be great to enforce linting on CI.

I propose using Ruff instead of flake8, it would avoid having to install a bunch of plugins and pyproject.toml configuration is supported.

Format could be included as well if the diff isn't to big.

@Viicos Viicos added the new feature Enhancement specifically adding a new feature (feature request should be used for issues instead) label Feb 16, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Dev Board Feb 16, 2024
@behackl
Copy link
Member

behackl commented Apr 20, 2024

I like the idea and have heard many good things about ruff. It would be nice to see a branch with this!

@JasonGrace2282 JasonGrace2282 linked a pull request May 21, 2024 that will close this issue
2 tasks
@JasonGrace2282 JasonGrace2282 added this to the v0.19.0 milestone May 21, 2024
@JasonGrace2282
Copy link
Member

JasonGrace2282 commented May 22, 2024

Tracking PRs:
If you want to help, just send a message here and I'll add your PR to the list :)

Formatting

Linting

@JasonGrace2282 JasonGrace2282 added good first issue Good for newcomers help wanted We would appreciate help on this issue/PR labels Jul 19, 2024
@JasonGrace2282 JasonGrace2282 modified the milestones: v0.19.0, v0.20.0 Jul 23, 2024
@JasonGrace2282 JasonGrace2282 added tracking and removed new feature Enhancement specifically adding a new feature (feature request should be used for issues instead) labels Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted We would appreciate help on this issue/PR tracking
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

3 participants