Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some typehints in mobject.py #3668

Merged
merged 4 commits into from
Apr 20, 2024
Merged

Fix some typehints in mobject.py #3668

merged 4 commits into from
Apr 20, 2024

Commits on Apr 1, 2024

  1. refactor(mobject): fix some typehints 

    * Move typing_extensions import under `if TYPE_CHECKING`
* Change from using `def animate(self: T ,...) -> T` to `def
  animate(self, ...) -> Self` as stated in PEP 673
* Fix incorrect usage of `T` in a method
    @JasonGrace2282
    JasonGrace2282 committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    653a01e View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    eeab7a9 View commit details
    Browse the repository at this point in the history

  3. move updaters type alias into TYPE_CHECKING

    @JasonGrace2282
    JasonGrace2282 committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    1c4b359 View commit details
    Browse the repository at this point in the history

  4. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    e47e617 View commit details
    Browse the repository at this point in the history