Optimized manim.utils.bezier.is_closed()
#3768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chopan050
added
performance
pr:easy review
JasonGrace2282
approved these changes
May 17, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Related PRs: #3281, #3767
In
manim.utils.bezier, in the functionis_closed(), repeatedly usingnp.allclose()to compare only two 3D points each time is actually very expensive and takes a significant part of the total time ofget_smooth_handle_points(). So I rewrote it to simply "compare 1st coords, then compare 2nd coords, then compare 3rd coords", which resulted in a 5x speedup.Reviewer Checklist