Change from tempconfig to a config fixture in tests #3853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonGrace2282
added
enhancement
JasonGrace2282
force-pushed
the
config-fixture
branch
from
926e962 to
57e96f4
Compare
behackl
approved these changes
Jul 12, 2024
Comment on lines
+53
to
+63
| tmp_cfg = tempfile.NamedTemporaryFile("w", dir=tmp_path, delete=False) | ||
| tmp_cfg.write( | ||
| """ | ||
| [CLI] | ||
| media_dir = this_is_my_favorite_path | ||
| video_dir = {media_dir}/videos | ||
| frame_height = 10 | ||
| """, | ||
| ) | ||
| tmp_cfg.close() | ||
| config.digest_file(tmp_cfg.name) |
There was a problem hiding this comment.
It practically doesn't matter because the tests are run in an isolated environment anyways, but what do you think about rewriting this test such that the config file is deleted in the end? The tests could just be moved inside an appropriate context manager. (I can take care of it.)
There was a problem hiding this comment.
That's probably a good idea, I'm all for cleaning up after our messes :)
| np.testing.assert_allclose(config.frame_height, 10.0) | ||
| np.testing.assert_allclose(config.frame_width, 10.0) | ||
| def test_frame_size_if_frame_width(config, using_opengl_renderer, tmp_path): | ||
| tmp_cfg = tempfile.NamedTemporaryFile("w", dir=tmp_path, delete=False) |
There was a problem hiding this comment.
same comment as above for this test
| frame_height = 10 | ||
| """, | ||
| ) | ||
| tmp_cfg.close() |
There was a problem hiding this comment.
actually, is this the same test as before? 🧐
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we were often doing
Which is just stupid, and it means that if one test forgets to do that, every test that depends on a value changed in that test is now screwed up. This is impossible to debug.
Instead, we can just create a fixture that resets
configafter every test.