Implement sections for scenes #3883

JasonGrace2282 · 2024-07-24T16:43:12Z

The usage is as seen in example_scenes/test_new_rendering.py

TODO

Implement the logic for scenes
Get skipping sections working

* feat: Animation.set_default Adds set_default class method to Animation class based on existing implementation for Mobject class. Addresses issue ManimCommunity#3142 * test: added missing test * fix: docstring formatting --------- Co-authored-by: Benjamin Hackl <devel@benjamin-hackl.at>

* pyproject * Autofixes from pre-commit * use get over get(x, None) Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com> --------- Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>

updates: - [github.com/astral-sh/ruff-pre-commit: v0.5.2 → v0.5.4](astral-sh/ruff-pre-commit@v0.5.2...v0.5.4) - [github.com/pre-commit/mirrors-mypy: v1.10.1 → v1.11.0](pre-commit/mirrors-mypy@v1.10.1...v1.11.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

…into scene-sections

…ty#3882) * Add config for bugbear/comprehensions note: flake8-comprehensions has 0 changes to the files * Safe fixes from pre-commit * Manual changes to make pre-commit pass * Remove deps from pyproject

Authors can change this behavior by writing new managers. This makes it more clear when conflicting plugins exist

…animCommunity#3884) * Config for flake8-builtins * Manual changes for flake8-builtins

* add colorscale to plot * Update manim/mobject/graphing/coordinate_systems.py Co-authored-by: Benjamin Hackl <devel@benjamin-hackl.at> * updated typing and moved one line * added test * fix input_to_graph_point error * Performance improvement by using cairo color drawing * Add OpenGL support * Add OpenGL tests and split test for x and y axis for more behavior coverage * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updated gradient_line tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: Benjamin Hackl <devel@benjamin-hackl.at> Co-authored-by: MrDiver <mrdiverlp@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Francisco Manríquez Novoa <49853152+chopan050@users.noreply.github.com> Co-authored-by: chopan <francisco.manriquezn@usm.cl>

…nity#3885) * fix OpenGLMobject.invert * return self to match typehint

* Experimenting with an HSL class * Add some more functionality * Adding a lot of tests and implementing fully functional conversion between color spaces over proxy rgba * Fixing tests * Fixing typing * return str to normal * Additional documentation * Update manim/utils/color/core.py Co-authored-by: adeshpande <110117391+JasonGrace2282@users.noreply.github.com> * Update manim/utils/color/core.py Co-authored-by: adeshpande <110117391+JasonGrace2282@users.noreply.github.com> * Update manim/utils/color/core.py Co-authored-by: adeshpande <110117391+JasonGrace2282@users.noreply.github.com> * Update manim/utils/color/core.py Co-authored-by: adeshpande <110117391+JasonGrace2282@users.noreply.github.com> * Fix documentation and typing and revamp operators to respect color spaces * Fix color operator typing and add operator tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix typeguard * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Import ManimFloat * Update manim/utils/color/core.py Co-authored-by: Aarush Deshpande <110117391+JasonGrace2282@users.noreply.github.com> * Update manim/utils/color/core.py Co-authored-by: Aarush Deshpande <110117391+JasonGrace2282@users.noreply.github.com> * Add docstring to _internal_space * naming of functions according to pep8 * Fix naming * Update manim/utils/color/core.py Co-authored-by: Aarush Deshpande <110117391+JasonGrace2282@users.noreply.github.com> * Update manim/utils/color/core.py Co-authored-by: Aarush Deshpande <110117391+JasonGrace2282@users.noreply.github.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: Jason Grace <110117391+JasonGrace2282@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

JasonGrace2282 · 2024-07-26T00:57:15Z

Just realized that rendering a Text mobject is incredibly slow... debugging needed.

updates: - [github.com/astral-sh/ruff-pre-commit: v0.5.4 → v0.5.5](astral-sh/ruff-pre-commit@v0.5.4...v0.5.5) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

ManimCommunity#3890) * Replace the TypeError message code in the _typecheck_input method in the DrawBorderThenFill class. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

…cene-sections

…into scene-sections

JasonGrace2282 · 2024-08-02T14:25:46Z

The fill_color of Tex Mobjects is currently broken, but I think it can be fixed in a later PR.

This allows for **kwargs to be typed

christopher-hampson and others added 8 commits July 22, 2024 13:37

Use ruff instead of flake8-simplify (ManimCommunity#3873)

f463423

* pyproject * Autofixes from pre-commit * use get over get(x, None) Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com> --------- Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>

Implement sections for scenes

49b9907

turn off write-to-movie

772a5f4

Fix overloads

347490d

Better implementation

5c5f073

change default

34bc627

JasonGrace2282 added the experimental label Jul 24, 2024

JasonGrace2282 added 3 commits July 24, 2024 15:00

fix skip and start work on actually getting it to work on live preview

8c41c6e

Merge branch 'experimental' of https://github.com/ManimCommunity/manim …

6f1d983

…into scene-sections

Small bugfix

cff225c

JasonGrace2282 marked this pull request as ready for review July 25, 2024 01:24

JasonGrace2282 marked this pull request as draft July 25, 2024 01:24

JasonGrace2282 and others added 10 commits July 24, 2024 21:48

remove save-as-gif

3f52786

better test scene

099eff7

Update pyproject to use python 3.10

1cb48f5

Change flake8-comprehensions and flake8-bugbear to ruff (ManimCommuni…

d6dac76

…ty#3882) * Add config for bugbear/comprehensions note: flake8-comprehensions has 0 changes to the files * Safe fixes from pre-commit * Manual changes to make pre-commit pass * Remove deps from pyproject

Remove plugins

f86ec80

Authors can change this behavior by writing new managers. This makes it more clear when conflicting plugins exist

Rename parameters and variables conflicting with builtin functions (M…

3a4ab4c

…animCommunity#3884) * Config for flake8-builtins * Manual changes for flake8-builtins

Fix :meth:.OpenGLMobject.invert not reassembling family (ManimCommu…

2075f82

…nity#3885) * fix OpenGLMobject.invert * return self to match typehint

Some more cleanup

0a6562a

JasonGrace2282 and others added 5 commits July 28, 2024 08:31

Fix typo from HSV PR (ManimCommunity#3887)

5bda107

[pre-commit.ci] pre-commit autoupdate (ManimCommunity#3889)

85d9ac8

updates: - [github.com/astral-sh/ruff-pre-commit: v0.5.4 → v0.5.5](astral-sh/ruff-pre-commit@v0.5.4...v0.5.5) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Improve sections and rewrite progressbar

0585c1f

fix inheritance of ProgressBar

b309fa5

JasonGrace2282 added 8 commits July 30, 2024 12:01

Mark SceneSection as typing.final

48a1f0f

fix incorrect example

775ef8a

Convert SceneSection to dataclass

a92e88f

Add SceneSection.order to __str__/__repr__

d7055e8

override SceneSection.__str__

9b0dca2

Merge branch 'main' of https://github.com/ManimCommunity/manim into s…

7095aaf

…cene-sections

pre-commit fixes

ce26a56

fix file writer failing with write_to_movie

5c10f98

JasonGrace2282 marked this pull request as ready for review July 30, 2024 18:44

rearrange so that saving sections is more intuitive

835a1ac

JasonGrace2282 mentioned this pull request Jul 30, 2024

Experimental Progress Tracker #3817

Open

19 tasks

JasonGrace2282 added 5 commits July 30, 2024 16:25

minor fixes with saving state

e1f9f63

Rewrite sections and fix section docs

f03c348

Merge branch 'experimental' of https://github.com/ManimCommunity/manim …

e08c38f

…into scene-sections

Fix bug with copying families

b410d77

General improvements to various parts of the code

80c67ae

JasonGrace2282 added 4 commits August 2, 2024 10:45

General cleanup + TypedDict for OpenGL(V)Mobject

4ccc64e

This allows for **kwargs to be typed

Readd always/f_always

27ee2f5

Drop support for more config options

4145545

fix cairo_camera by removing it

80e08d2

JasonGrace2282 merged commit 7844c84 into ManimCommunity:experimental Aug 3, 2024
3 of 4 checks passed

JasonGrace2282 deleted the scene-sections branch August 3, 2024 00:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implement sections for scenes #3883

Implement sections for scenes #3883

Uh oh!

JasonGrace2282 commented Jul 24, 2024 •

edited

Loading

Uh oh!

JasonGrace2282 commented Jul 26, 2024

Uh oh!

JasonGrace2282 commented Aug 2, 2024

Uh oh!

Uh oh!

Uh oh!

Implement sections for scenes #3883

Implement sections for scenes #3883

Uh oh!

Conversation

JasonGrace2282 commented Jul 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO

Uh oh!

JasonGrace2282 commented Jul 26, 2024

Uh oh!

JasonGrace2282 commented Aug 2, 2024

Uh oh!

Uh oh!

Uh oh!

JasonGrace2282 commented Jul 24, 2024 •

edited

Loading