-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish documentation of manim.utils.color.core
and remove interpolate_array()
#4065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behackl
approved these changes
Jan 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a coarse reading of the documentation changes and reviewed the typing changes -- thanks for the hard work with the color module, this is a substantial improvement!
Given that the docs seem fine and mypy appears happy, I'm merging this.
behackl
reviewed
Jan 19, 2025
chopan050
changed the title
Complete typing of
Polish documentation of Jan 19, 2025
manim.utils.color
and polish its documentationmanim.utils.color
and remove interpolate_array()
chopan050
changed the title
Polish documentation of
Polish documentation of Jan 19, 2025
manim.utils.color
and remove interpolate_array()
manim.utils.color.core
and remove interpolate_array()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: PR #3999 already typed the entire
manim.utils
module, includingmanim.utils.color.core
, before I did. Therefore, I changed this PR's name to focus on the other things it does: polish docs and removeinterpolate_array()
.Stopped ignoring MyPy errors formanim.utils.color
.Fixed MyPy errors inmanim.utils.color.core
.manim.utils.color.core.interpolate_array()
function, becausemanim.utils.bezier.interpolate()
already exists and provides the exact same functionality.Links to added or changed documentation pages
https://manimce--4065.org.readthedocs.build/en/4065/reference/manim.utils.color.core.html
Reviewer Checklist