Skip to content

Add type annotations to text_mobject.py #4381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Aug 11, 2025
Merged

Add type annotations to text_mobject.py #4381

merged 27 commits into from
Aug 11, 2025
+124 −130

Conversation

henrikmidtiby
Copy link
Contributor

Overview: What does this pull request change?

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

@henrikmidtiby
Activated typechecking in mobject.text.*
eabb0ee 
Error count: 156
@henrikmidtiby
Fixed typing errors in mobject/text/code_mobject.py
866ea02
@henrikmidtiby
Add type annotations to mobject/text/numbers.py
952b302
@henrikmidtiby
Import ManimColor on every run
c6f7059
@henrikmidtiby
Add type annotations to mobject/text/tex_mobject.py
648277a
@henrikmidtiby
Return the object itself from init_colors
f56effd
@henrikmidtiby
Fix issue.
e76e53b
@henrikmidtiby
Add type annotations to mobject/text/text_mobject.py
94382c5
@henrikmidtiby
Add type annotations to camera/camera.py
19157a0
@henrikmidtiby
Remove deprecated code
94215e0
@henrikmidtiby
First pass through text_mobject.py for adding type annotations.
7f24484
@henrikmidtiby
More work on typing text_mobject.py
1ae6ac5
@henrikmidtiby
Merge remote-tracking branch 'upstream/main' into Typing_camera
46fc244 
# Conflicts:
#	manim/camera/camera.py
#	manim/mobject/svg/svg_mobject.py
#	manim/mobject/text/code_mobject.py
#	manim/mobject/text/numbers.py
#	manim/mobject/text/tex_mobject.py
#	manim/mobject/types/image_mobject.py
#	mypy.ini
@henrikmidtiby
Hunting down the last typing issues.
001e0c8
@henrikmidtiby
Ensure that color_gradient always returns a list
2649c5f
@henrikmidtiby
Merge remote-tracking branch 'upstream/main' into TypingTextMobject
589abb1
@henrikmidtiby
Merge remote-tracking branch 'upstream/main' into Typing_camera
61a1359 
# Conflicts:
#	mypy.ini
@henrikmidtiby
Code cleanup
2842c09
@henrikmidtiby
Merge branch 'TypingTextMobject' into Typing_camera
f5529ef 
# Conflicts:
#	manim/mobject/text/text_mobject.py
#	mypy.ini
@henrikmidtiby
Code cleanup
eeacbd7
@github-project-automation github-project-automation bot moved this to 🆕 New in Dev Board Aug 8, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 8, 2025
View reviewed changes
henrikmidtiby
henrikmidtiby commented Aug 8, 2025
View reviewed changes
@henrikmidtiby henrikmidtiby marked this pull request as ready for review August 8, 2025 11:31
chopan050
chopan050 requested changes Aug 11, 2025
View reviewed changes
Copy link
Contributor

@chopan050 chopan050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left some comments and requests:

@github-project-automation github-project-automation bot moved this from 🆕 New to 👀 In review in Dev Board Aug 11, 2025
@henrikmidtiby
Suggestions from Chopan50
7d20561
@henrikmidtiby
Merge remote-tracking branch 'upstream/main' into TypingTextMobject
99192c7 
# Conflicts:
#	manim/mobject/text/text_mobject.py
#	manim/utils/color/core.py
@henrikmidtiby
Fixes
2ef82ac
@henrikmidtiby henrikmidtiby mentioned this pull request Aug 11, 2025
Merged
3 tasks
chopan050
chopan050 requested changes Aug 11, 2025
View reviewed changes
Copy link
Contributor

@chopan050 chopan050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left two more comments:

chopan050
chopan050 approved these changes Aug 11, 2025
View reviewed changes
Copy link
Contributor

@chopan050 chopan050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-project-automation github-project-automation bot moved this from 👀 In review to 👍 To be merged in Dev Board Aug 11, 2025
@chopan050 chopan050 enabled auto-merge (squash) August 11, 2025 20:58
@chopan050 chopan050 merged commit 03a9414 into ManimCommunity:main Aug 11, 2025
21 checks passed
@github-project-automation github-project-automation bot moved this from 👍 To be merged to ✅ Done in Dev Board Aug 11, 2025
@henrikmidtiby henrikmidtiby deleted the TypingTextMobject branch August 12, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chopan050 chopan050 chopan050 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Dev Board
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@henrikmidtiby @chopan050 @behackl