Skip to content

Simplify the function remove_invisible_chars in text_mobject.py #4394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 13, 2025
Merged

Simplify the function remove_invisible_chars in text_mobject.py #4394

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f4f2f46
Refactor suggested by Chopan50
henrikmidtiby Aug 11, 2025
f4f7387
Code cleanup
henrikmidtiby Aug 13, 2025
7cd7111
Merge remote-tracking branch 'upstream/main' into RefactorExcludeDots
henrikmidtiby Aug 13, 2025
012744f
...
henrikmidtiby Aug 13, 2025
f990de5
Merge branch 'main' into RefactorExcludeDots
chopan050 Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions manim/mobject/text/text_mobject.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ def construct(self):
from manim.constants import *
from manim.mobject.geometry.arc import Dot
from manim.mobject.svg.svg_mobject import SVGMobject
from manim.mobject.text.code_mobject import Code
from manim.mobject.types.vectorized_mobject import VGroup, VMobject
from manim.typing import Point3D
from manim.utils.color import ManimColor, ParsableManimColor, color_gradient
Expand Down Expand Up @@ -101,14 +100,6 @@ def remove_invisible_chars(mobject: VMobject) -> VMobject:
:class:`~.SVGMobject`
The SVGMobject without unwanted invisible characters.
"""
# TODO: Refactor needed
iscode = False
if isinstance(mobject, Text):
mobject = mobject[:]
elif isinstance(mobject, Code):
iscode = True
code = mobject
mobject = mobject.code
mobject_without_dots = VGroup()
if isinstance(mobject[0], VGroup):
for submob in mobject:
Expand All @@ -117,10 +108,6 @@ def remove_invisible_chars(mobject: VMobject) -> VMobject:
)
else:
mobject_without_dots.add(*(k for k in mobject if not isinstance(k, Dot)))
if iscode:
assert isinstance(code, Code)
code.code = mobject_without_dots
return code
return mobject_without_dots


Expand Down
Loading