Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rustc-dev component in nightly test #199

Merged
merged 1 commit into from
Nov 12, 2019
Merged

Add rustc-dev component in nightly test #199

merged 1 commit into from
Nov 12, 2019

Conversation

Munksgaard
Copy link
Collaborator

@Munksgaard Munksgaard commented Nov 12, 2019

rustc has been removed from the nightly rust distribution. In order to use it (for extern crate rustc), we need to add the rustc-dev component first.

@Munksgaard Munksgaard changed the title Add rustc-dev component before testing nightly Add rustc-dev component in nightly test Nov 12, 2019
rustc has been removed from the nightly rust distribution. In order to use
it (for `extern crate rustc`), we need to add the `rustc-dev` component first.
@Munksgaard
Copy link
Collaborator Author

Munksgaard commented Nov 12, 2019

This PR got me thinking, perhaps our feature-system should be the other way around? Right now, stable is an opt-out system for nightly only features (and now also for an external component requirement), whereas a hypothetical rustc would be an opt-in for additional features where the rustc crate is needed.

@Munksgaard Munksgaard merged commit 4371d7d into master Nov 12, 2019
@Munksgaard Munksgaard deleted the fix-travis branch November 12, 2019 14:41
@laumann
Copy link
Collaborator

laumann commented Nov 12, 2019

This PR got me thinking, perhaps our feature-system should be the other way around?

You mean something like #135? In particular this comment.

@Munksgaard
Copy link
Collaborator Author

This PR got me thinking, perhaps our feature-system should be the other way around?

You mean something like #135? In particular this comment.

Exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants