Lock coverage files #259
Merged
Lock coverage files #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @Manishearth. |
|
@Manishearth Would it be possible to get a new release with this fix? I suspect this bug was in part the cause of the recent rustup failure: https://github.com/rust-lang/rust-clippy/actions/runs/3106438892/jobs/5033324694#step:11:911 |
|
@smoelius v0.9.0 has now been published and includes your fix :-) Thanks for the contribution! |
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Sep 23, 2022
Upgrade `compiletest-rs` dependency From `0.8` to `0.9`. The new version includes a [fix](Manishearth/compiletest-rs#259) for what I suspect was one cause of the recent rustup failure: https://github.com/rust-lang/rust-clippy/actions/runs/3106438892/jobs/5033324694#step:11:911 changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests a method for locking coverage files when writing to them.
Currently, there appears to be a race. Specifically, the
testercrate runs test functions in separate threads, similar to howlibtestdoes. Thus, the test functions' writes to the coverage file can become interleaved, causing the file to become corrupted.I have observed corrupted coverage files while testing Clippy, and I suspect this to be the cause.