Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement clone for LockFreeFrozenVec #57

Merged
merged 10 commits into from
Oct 24, 2023
Merged

feat: implement clone for LockFreeFrozenVec #57

merged 10 commits into from
Oct 24, 2023

Conversation

aminya
Copy link
Contributor

@aminya aminya commented Aug 9, 2023 •
edited
Loading

Fixes #33

Manishearth
Manishearth requested changes Aug 10, 2023
View reviewed changes
Copy link
Owner

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please uphold the safety invariants of the types

src/index_map.rs Outdated Show resolved Hide resolved
Manishearth
Manishearth requested changes Aug 10, 2023
View reviewed changes
src/sync.rs Outdated Show resolved Hide resolved
oli-obk
oli-obk reviewed Sep 26, 2023
View reviewed changes
Copy link
Contributor

@oli-obk oli-obk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also add some tests that clone LockFreeFrozenVec (and add enough elements first to get 2 or 3 buffers)

src/sync.rs Outdated Show resolved Hide resolved
src/sync.rs Outdated Show resolved Hide resolved
src/sync.rs Outdated Show resolved Hide resolved
src/sync.rs Outdated Show resolved Hide resolved
@aminya
Copy link
Contributor Author

aminya commented Sep 27, 2023

please also add some tests that clone LockFreeFrozenVec (and add enough elements first to get 2 or 3 buffers

Sure. I am OK to add more tests. However, I'd rather #62 is merged first so that I can just use assert_eq in the tests

@aminya aminya requested a review from oli-obk September 27, 2023 04:47
aminya
aminya commented Sep 27, 2023
View reviewed changes
src/sync.rs Outdated Show resolved Hide resolved
oli-obk
oli-obk suggested changes Sep 27, 2023
View reviewed changes
src/sync.rs Outdated Show resolved Hide resolved
src/sync.rs Outdated Show resolved Hide resolved
src/sync.rs Outdated Show resolved Hide resolved
src/sync.rs Outdated Show resolved Hide resolved
@aminya aminya mentioned this pull request Oct 23, 2023
Merged
@aminya aminya changed the title feat: implement clone for all the containers feat: implement clone for LockFreeFrozenVec Oct 23, 2023
@Manishearth Manishearth merged commit 692b89b into Manishearth:master Oct 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk approved these changes

@Manishearth Manishearth Awaiting requested review from Manishearth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FrozenMap and friends should implement Clone
3 participants
@aminya @oli-obk @Manishearth