Skip to content

Commit

Permalink
nightly
Browse files Browse the repository at this point in the history
  • Loading branch information
Manishearth committed Dec 19, 2024
1 parent 1656eab commit 19a5c87
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ Our wider testsuite is organized as `ci-job-foo` make tasks corresponding to eac
<br/>

- `ci-job-test-c`: Runs all C/C++ FFI tests; mostly important if you're changing the FFI interface.
+ Requires `clang-17` and `lld-17` with the `gold` plugin (APT packages `llvm-17` and `lld-17`).
+ Requires `clang-18` and `lld-18` with the `gold` plugin (APT packages `llvm-18` and `lld-18`).
- `ci-job-test-js`: Runs all JS/WASM/Node FFI tests; mostly important if you're changing the FFI interface.
+ Requires Node.js version 16.18.0. This may not the one offered by the package manager; get it from the NodeJS website or `nvm`.
- `ci-job-nostd`: Builds ICU4X for a `#[no_std]` target to verify that it's compatible.
Expand Down
6 changes: 3 additions & 3 deletions tutorials/c-tiny/fixeddecimal/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ ALL_HEADERS := $(wildcard ${HEADERS}/*)
$(ALL_HEADERS):

GCC := gcc
CLANG := clang-17
LLD := lld-17
LLVM_COMPATIBLE_NIGHTLY = "nightly-2024-01-01"
CLANG := clang-18
LLD := lld-18
LLVM_COMPATIBLE_NIGHTLY = "nightly-2024-07-01"

baked_data/macros.rs:
cargo install --path ../../../provider/icu4x-datagen --root target
Expand Down
6 changes: 3 additions & 3 deletions tutorials/c-tiny/segmenter/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ ALL_HEADERS := $(wildcard ${HEADERS}/*)
$(ALL_HEADERS):

GCC := gcc
CLANG := clang-17
LLD := lld-17
LLVM_COMPATIBLE_NIGHTLY = "nightly-2024-01-01"
CLANG := clang-18
LLD := lld-18
LLVM_COMPATIBLE_NIGHTLY = "nightly-2024-07-01"

target/debug/libicu_capi.a: FORCE
cargo rustc -p icu_capi --crate-type staticlib --no-default-features --features icu_capi/compiled_data,icu_capi/segmenter,icu_capi/std
Expand Down
2 changes: 1 addition & 1 deletion tutorials/js-tiny/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ ICU_CAPI := $(shell cargo metadata --format-version 1 | jq '.packages[] | select
HEADERS := ${ICU_CAPI}/bindings/js
ALL_HEADERS := $(wildcard ${HEADERS}/*)

LLVM_COMPATIBLE_NIGHTLY ?= "nightly-2024-01-01"
LLVM_COMPATIBLE_NIGHTLY ?= "nightly-2024-07-01"

$(ALL_HEADERS):

Expand Down
2 changes: 1 addition & 1 deletion tutorials/js-tiny/ld.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def main():
else:
new_argv += [arg]
is_export = False
result = subprocess.run(["lld-17"] + new_argv, stdout=sys.stdout, stderr=sys.stderr)
result = subprocess.run(["lld-18"] + new_argv, stdout=sys.stdout, stderr=sys.stderr)
return result.returncode

if __name__ == "__main__":
Expand Down

0 comments on commit 19a5c87

Please sign in to comment.