Make fraction and num_bigint an optional dep of datagen

Manishearth · Dec 13, 2023 · 75898a9 · 75898a9
1 parent 94fa985
commit 75898a9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/provider/datagen/Cargo.toml b/provider/datagen/Cargo.toml
@@ -88,8 +88,8 @@ zip = { version = ">=0.5, <0.7", default-features = false, features = ["deflate"
 rayon = { version = "1.5", optional = true }
 ureq = { version = "2", optional = true }
 
-fraction = {version = "0.14.0", default-features = false }
-num-bigint = { version = "0.4.4", default-features = false }
+fraction = { version = "0.14.0", default-features = false, optional = true }
+num-bigint = { version = "0.4.4", default-features = false, optional = true }
 
 
 # Dependencies for "bin" feature
@@ -130,7 +130,7 @@ icu_compactdecimal = ["dep:icu_compactdecimal"]
 icu_displaynames = ["dep:icu_displaynames"]
 icu_relativetime = ["dep:icu_relativetime"]
 icu_transliterate = ["dep:icu_transliterate"]
-icu_unitsconversion = ["dep:icu_unitsconversion"]
+icu_unitsconversion = ["dep:icu_unitsconversion", "dep:fraction", "dep:num-bigint"]
 experimental_components = [
     "icu_compactdecimal",
     "icu_displaynames",

diff --git a/tools/depcheck/src/allowlist.rs b/tools/depcheck/src/allowlist.rs
@@ -142,14 +142,12 @@ pub const EXTRA_DATAGEN_DEPS: &[&str] = &[
     "databake-derive",
     "elsa",
     "erased-serde",
-    "fraction",
     "icu_codepointtrie_builder",
     "itertools",
     "itoa",
     "matrixmultiply",
     "ndarray",
     "num",
-    "num-bigint",
     "num-complex",
     "num-integer",
     "num-iter",