-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove noqa #171
Remove noqa #171
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I like the approach using FutureWarnings
alphabase.constants.element
toalphabase.constants.atom
; add FutureWarning.alphabase.peptide.precursor.is_precursor_sorted()
toalphabase.peptide.precursor.is_precursor_refined()
; add FutureWarning.alphabase.peptide.precursor.calc_precursor_mz()
toalphabase.peptide.precursor.update_precursor_mz()
, and add FutureWarning.