Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove noqa #171

Merged
merged 7 commits into from
May 21, 2024
Merged

Remove noqa #171

merged 7 commits into from
May 21, 2024

Conversation

jalew188
Copy link
Collaborator

  • Fix noqa: modify imports of alphabase.constants.element to alphabase.constants.atom; add FutureWarning.
  • Fix noqa: modify imports of alphabase.peptide.precursor.is_precursor_sorted() to alphabase.peptide.precursor.is_precursor_refined(); add FutureWarning.
  • Fix noqa: modify imports of alphabase.peptide.precursor.calc_precursor_mz() to alphabase.peptide.precursor.update_precursor_mz(), and add FutureWarning.

@jalew188 jalew188 requested review from GeorgWa and mschwoer May 19, 2024 11:41
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jalew188 jalew188 marked this pull request as ready for review May 19, 2024 11:41
Copy link
Collaborator

@GeorgWa GeorgWa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

alphabase/peptide/precursor.py Show resolved Hide resolved
Copy link
Contributor

@mschwoer mschwoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I like the approach using FutureWarnings

alphabase/spectral_library/base.py Outdated Show resolved Hide resolved
@jalew188 jalew188 merged commit c6b7b0f into development May 21, 2024
2 checks passed
@jalew188 jalew188 deleted the remove_noqa branch May 21, 2024 08:30
@jalew188 jalew188 linked an issue May 24, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove import sides effects and wildcard importing
3 participants