Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add psm reader tests #231

Merged
merged 8 commits into from
Nov 15, 2024
Merged

Add psm reader tests #231

merged 8 commits into from
Nov 15, 2024

Conversation

mschwoer
Copy link
Contributor

@mschwoer mschwoer commented Nov 12, 2024

  • Add integration tests for the PSM Readers to be safe against regressions.
  • make some things private that are not used within other packages within the MannLabs org (could ofc break others)

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@GeorgWa GeorgWa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alphabase/spectral_library/reader.py Show resolved Hide resolved
@mschwoer mschwoer merged commit 42646da into development Nov 15, 2024
2 checks passed
@mschwoer mschwoer deleted the add_psm_reader_tests branch November 15, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants