Adding Charged Fragment Types to MS2 Model Weights #228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a small but useful modification to the MS2 model interface and
ModelMS2Bert
,by including charged fragment types as an attribute within the model weights. With this change, charged fragment types are saved and loaded from disk, making it easier to adjust fragment types for prediction and training.Main Benefits
mask_modloss
argument.I've added a notebook (
adapt_charged_fragtypes.ipynb
) that walks through different use cases, including compatibility with older weight formats. It would be great if you could take a look and let me know if anything is missing.This update modifies
ModelMS2Bert
, but if this approach looks good, I’d be happy to extend it to other architectures in a follow-up PR.