Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic linting #48

Closed
mschwoer opened this issue May 22, 2024 · 0 comments
Closed

Basic linting #48

mschwoer opened this issue May 22, 2024 · 0 comments
Assignees

Comments

@mschwoer
Copy link

WHO
Developers
WHAT
Have properly linted code
WHY
Best practises, less overhead when developing

AC

  • Code is linted once using ruff (with sensible defaults), all issues are fixed (either by code changes or by applying noqa)
  • pre-commit hook is in place that takes care about the linting (also in CI)
  • add default pre-commit hooks (whitespaces, line-endings)
    cf. #153: apply ruff default formatting alphabase#154
@mschwoer mschwoer self-assigned this May 22, 2024
mschwoer added a commit that referenced this issue May 22, 2024
mschwoer added a commit that referenced this issue May 22, 2024
mschwoer added a commit that referenced this issue May 22, 2024
mschwoer added a commit that referenced this issue May 22, 2024
mschwoer added a commit that referenced this issue May 22, 2024
@jalew188 jalew188 closed this as completed Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants