Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Log the errors when the project release configuration file is not valid. #45

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

M0nkeySan
Copy link
Collaborator

What

Add an error log when the configuration file validation fails.

Why

Currently if the configuration file is invalid, the log is just The config file should contain an array of valid project configurations which doesn't really help.

@M0nkeySan M0nkeySan requested a review from pfongkye October 28, 2024 09:40
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.38%. Comparing base (56b0f4b) to head (c5518c3).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
+ Coverage   78.36%   78.38%   +0.02%     
==========================================
  Files          94       94              
  Lines        1895     1897       +2     
  Branches      345      346       +1     
==========================================
+ Hits         1485     1487       +2     
+ Misses        401      382      -19     
- Partials        9       28      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@M0nkeySan M0nkeySan merged commit 982760e into ManoManoTech:main Oct 28, 2024
3 checks passed
pfongkye pushed a commit to pfongkye/homer that referenced this pull request Nov 7, 2024
…not valid. (ManoManoTech#45)

chore: Add a log when the configuration file validation fails.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants