-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for supported multilocation type when creating/updating assets #1061
Open
Garandor
wants to merge
10
commits into
manta
Choose a base branch
from
garandor/validate-multilocation
base: manta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+44
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garandor
added
C-bug
Category: Issues documenting a bug
A-manta
Area: Issues and PRs related to the Manta Runtime
A-calamari
Area: Issues and PRs related to the Calamari Runtime
A-dolphin
Area: Issues and PRs related to the Dolphin Runtime
L-fixed
Log: Issues and PRs related to bug fixes
labels
Apr 4, 2023
Signed-off-by: Adam Reif <Garandor@manta.network>
Garandor
force-pushed
the
garandor/validate-multilocation
branch
from
April 4, 2023 02:00
6ad4586
to
ed10238
Compare
…ation Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Garandor
force-pushed
the
garandor/validate-multilocation
branch
from
April 11, 2023 21:39
b9f1eb0
to
a41e44b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-calamari
Area: Issues and PRs related to the Calamari Runtime
A-dolphin
Area: Issues and PRs related to the Dolphin Runtime
A-manta
Area: Issues and PRs related to the Manta Runtime
C-bug
Category: Issues documenting a bug
L-fixed
Log: Issues and PRs related to bug fixes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an asset has a valid Multilocation, we only allow to register it if we're sure it can be sent via xtokens ( i.e. passes the
Contains
filter )Signed-off-by: Adam Reif Garandor@manta.network## Description
Before we can approve this PR for merge, please make sure that all the following items have been checked off:
L-
group to this PRA-
andC-
groups to this PRA-calamari
,A-dolphin
and/orA-manta
if your changes are meant for/impact either of these (CI depends on it)Files changed
in the Github PR explorer.Situational Notes:
BaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime
. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]
items to check for any.