Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Happy new year🥂 #1290

Merged
merged 4 commits into from
Jan 5, 2024
Merged

Happy new year🥂 #1290

merged 4 commits into from
Jan 5, 2024

Conversation

Dengjianping
Copy link
Contributor

@Dengjianping Dengjianping commented Jan 2, 2024

Description

  1. Update copyright year to 2024.
  2. Remove storage migration from runtime
  3. Add a script about reconstructing pallet's storage.
  4. Add a tips about how to specify base-path while use zombienet.

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.
  • Add A-integration-test-checks to run start-integration-test-checks (Required)
  • Add A-benchmark-checks to run start-benchmark-check (Required)
  • Add A-unit-test-checks to run start-unit-test-checks (Required)
  • Add A-congestion-test-checks to run start-integration-test-checks (Optional)

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping Dengjianping requested a review from a team as a code owner January 2, 2024 03:44
@Dengjianping Dengjianping added A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime A-benchmark-checks A-integration-test-checks A-unit-test-checks labels Jan 2, 2024
@Dengjianping Dengjianping self-assigned this Jan 2, 2024
@Dengjianping Dengjianping added the L-changed Log: Issues and PRs related to changes label Jan 2, 2024
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping Dengjianping merged commit dca8bdc into manta Jan 5, 2024
19 checks passed
@Dengjianping Dengjianping deleted the happy-new-year branch January 5, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-benchmark-checks A-calamari Area: Issues and PRs related to the Calamari Runtime A-integration-test-checks A-manta Area: Issues and PRs related to the Manta Runtime A-unit-test-checks L-changed Log: Issues and PRs related to changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants