Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unfilter XTokens on Manta #1320

Merged
merged 8 commits into from
Mar 15, 2024
Merged

unfilter XTokens on Manta #1320

merged 8 commits into from
Mar 15, 2024

Conversation

ferrell-code
Copy link
Contributor

@ferrell-code ferrell-code commented Mar 4, 2024

Description

Unfilters all xtoken calls on manta


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.
  • Add A-integration-test-checks to run start-integration-test-checks (Required)
  • Add A-benchmark-checks to run start-benchmark-check (Required)
  • Add A-unit-test-checks to run start-unit-test-checks (Required)
  • Add A-congestion-test-checks to run start-integration-test-checks (Optional)

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code ferrell-code added C-enhancement Category: An issue proposing an enhancement or a PR with one A-manta Area: Issues and PRs related to the Manta Runtime A-runtime Area: Issues and PRs related to Runtimes L-changed Log: Issues and PRs related to changes A-benchmark-checks A-integration-test-checks A-congestion-test-checks A-unit-test-checks labels Mar 4, 2024
Signed-off-by: Charles Ferrell <charlie@manta.network>
Copy link

github-actions bot commented Mar 4, 2024

⚠️ Congestion test: 1-day congestion cost (calamari-runtime) is NOT above the target daily congestion cost

Copy link

github-actions bot commented Mar 4, 2024

⚠️ Congestion test: 1-day congestion cost (manta-runtime) is NOT above the target daily congestion cost

Signed-off-by: Charles Ferrell <charlie@manta.network>
Signed-off-by: Charles Ferrell <charlie@manta.network>
Signed-off-by: Charles Ferrell <charlie@manta.network>
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code ferrell-code added the A-calamari Area: Issues and PRs related to the Calamari Runtime label Mar 11, 2024
Signed-off-by: Charles Ferrell <charlie@manta.network>
@Dengjianping Dengjianping merged commit 2d081b6 into manta Mar 15, 2024
20 checks passed
@Dengjianping Dengjianping deleted the fer-unfilter-xtoken branch March 15, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-benchmark-checks A-calamari Area: Issues and PRs related to the Calamari Runtime A-congestion-test-checks A-integration-test-checks A-manta Area: Issues and PRs related to the Manta Runtime A-runtime Area: Issues and PRs related to Runtimes A-unit-test-checks C-enhancement Category: An issue proposing an enhancement or a PR with one L-changed Log: Issues and PRs related to changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants