Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manta-PC] Update dependencies to v0.9.12 #242

Merged
merged 12 commits into from
Nov 6, 2021

Conversation

ghzlatarev
Copy link
Contributor

@ghzlatarev ghzlatarev commented Nov 2, 2021

Description

closes #235
closes #239

Manta Changes

Client

  1. version from 3.0.8 to 3.0.9.

Runtime

  1. set RelayNetwork const to correct Kusama instead of Polkadot in the calamari runtime.
  2. pub type LocalOriginToLocation = (); means that no one can become XcmSendOrigin or XcmExecuteOrigin in Calamari/Manta runtimes.
  3. type XcmExecuteFilter = Nothing; means that even if somehow someone manages to becomes XcmExecuteOrigin their message will be filtered out because Nothings implementation of Contains trait will always return false.
  4. Removed associated type in pallet_session because of API change ---> DisabledValidatorsThreshold The relevant substrate PR is staking: only disable slashed validators and keep them disabled for whole era paritytech/substrate#9448

Upstream Changes

Polkadot Changes:

  1. Create a README for XCMv1 detailing notable changes paritytech/polkadot#4058
  2. validator-discovery: don't remove multiaddr of requested PeerIds  paritytech/polkadot#4036
  3. Dispatchable XCMs should translate to v0 paritytech/polkadot#4062
  4. Tidy up XCM errors in preparation for v2. paritytech/polkadot#3988
  5. Allow an Offset to Lease Periods paritytech/polkadot#3980
  6. Use WEIGHT_PER_SECOND Patch paritytech/polkadot#4077
  7. v0.9.12-rc2 paritytech/polkadot#4108
  8. Allow queries subscriptions - backport v0.9.12 paritytech/polkadot#4157
  9. Fix an off-by-one: revert rather than revert-to paritytech/polkadot#3991
  10. add disputes call to Rococo paritytech/polkadot#3993
  11. always broadcast tranche 0 assignments and add a delay before approval paritytech/polkadot#3904
  12. preserve finalized block in active leaves paritytech/polkadot#3997
  13. GHA: extrinsic ordering, new filter to generate a summary paritytech/polkadot#3631
  14. Make candidate validation timeouts configurable paritytech/polkadot#4001
  15. Re-configure offchain repeat frequency for elections paritytech/polkadot#3966
  16. collect included disputes from on-chain paritytech/polkadot#3924
  17. Update for warp sync paritytech/polkadot#3564
  18. Make most XCM APIs accept an Into<MultiLocation> where MultiLocation is accepted paritytech/polkadot#3627
  19. Fix democracy on-initialize weight paritytech/substrate#9890
  20. follow-chain testing mode for try-runtime (and revamp CLI configs).  paritytech/substrate#9788
  21. add parachains pallets to Polkadot runtime paritytech/polkadot#3815
  22. update BaseXcmWeight to match Kusama paritytech/polkadot#3911
    Release Checklist:
  23. Polkadot v0.9.12 Release checklist paritytech/polkadot#4095

Substrate Changes:

  1. staking: only disable slashed validators and keep them disabled for whole era paritytech/substrate#9448
  2. Use correct db path for parity-db paritytech/substrate#9971
  3. Rework Transaction Priority calculation paritytech/substrate#9834
  4. Introduce block authorship soft deadline paritytech/substrate#9663
  5. make the ws buffer size configurable paritytech/substrate#10013
  6. Disable log reloading by default paritytech/substrate#9966
  7. --dev implies --tmp paritytech/substrate#9938
  8. Quickly skip invalid transactions during block authorship. paritytech/substrate#9789
  9. More lenient mechanism for identifying stash accounts in purge_keys paritytech/substrate#10004
  10. Root origin always bypass all filter, other origin cannot bypass BaseCallFilter even when constructed from Root origin paritytech/substrate#9948
  11. Switch to using ss58-registry crate paritytech/substrate#9755

Cumulus Changes:

  1. Added Key in subcommand paritytech/cumulus#651
  2. Look at the upgrade go-ahead and restriction signals paritytech/cumulus#517
  3. https://github.com/paritytech/cumulus/pull/662/files
  4. disallow XCM execute on statemint paritytech/cumulus#663
  5. fix feature selection paritytech/cumulus#666
  6. Bump polkadot deps paritytech/cumulus#670
  7. Clean up the asset-tx-payment Pallet paritytech/cumulus#657
  8. Use safer template defaults for polkadot-v0.9.12, move to recognize, comment on Override for AdvertisedXcmVersion default paritytech/cumulus#690

statemine diffs between:

ede4d527c4fc5d84c43216b408a873625488574b -> 0.9.11
f5926c2f50df73bf36171b138241437131d76fff-> 0.9.12

Tests (Local --> Baikal)

  • Does key injection script work (only for calamari-testnet)
  • Check block production
  • Sudo system.setCode upgrade
  • Force transfer balances
  • Pass sudo to multi-sig account (try action like adding a Council member)
  • Upgrade with authorizeUpgrade + enactAuthorized
  • Check average block time is ~12 seconds
  • Check dropping and reconnecting a collator
  • Native binary replacement
  • Check relay chain XCM message upgrade
  • Check governance runtime upgrade

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (manta or manta-pc) with right title (start with [Manta] or [Manta-PC]),
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests.
  • Updated relevant documentation in the code.
  • Re-reviewed Files changed in the Github PR explorer.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. If this number is updated, then the spec_version must also be updated
  • If needed, notify the committer this is a draft-release and a tag is needed after merging the PR.
  • Verify benchmarks & weights have been updated for any modified runtime logics

@ghzlatarev ghzlatarev changed the title Update dependencies to 0.9.12 [Manta-PC] Update dependencies to 0.9.12 Nov 2, 2021
@ghzlatarev ghzlatarev changed the title [Manta-PC] Update dependencies to 0.9.12 [Manta-PC] Update dependencies to v0.9.12 Nov 2, 2021
node/src/service.rs Outdated Show resolved Hide resolved
runtime/calamari/Cargo.toml Outdated Show resolved Hide resolved
@ghzlatarev ghzlatarev marked this pull request as ready for review November 5, 2021 17:00
@ghzlatarev ghzlatarev self-assigned this Nov 5, 2021
@Dengjianping
Copy link
Contributor

Remember to update changelog.

@stechu
Copy link
Collaborator

stechu commented Nov 6, 2021

did a manual test for the upgrade. It passed on my local machine.

@stechu stechu merged commit 19f8d6b into manta-pc Nov 6, 2021
@stechu stechu deleted the ghzlatarev/polkadot-v0.9.12 branch November 6, 2021 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up compilation warnings Upgrade dependencies to v0.9.12-1
3 participants