Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose 9945 for checking relaychain's block number on parachain #435

Merged
merged 9 commits into from
Mar 11, 2022

Conversation

Dengjianping
Copy link
Contributor

@Dengjianping Dengjianping commented Mar 8, 2022

Signed-off-by: Dengjianping djptux@gmail.com

Description

Currently seems docker cannot parse bootnodes in ENTRYPOINT.
Originally, ENTRYPOINT in dockerfile like this:

ENTRYPOINT [\
  "/usr/local/bin/manta",\
  "--chain",\
  "/usr/share/calamari.json",\
  "--bootnodes",\
  "/dns/crispy.calamari.systems/tcp/30333/p2p/12D3KooWNE4LBfkYB2B7D4r9vL54YMMGsfAsXdkhWfBw8VHJSEQc", \
  "/dns/crunchy.calamari.systems/tcp/30333/p2p/12D3KooWL3ELxcoMGA6han3wPQoym5DKbYHqkWkCuqyjaCXpyJTt", \
  "/dns/hotdog.calamari.systems/tcp/30333/p2p/12D3KooWMHdpUCCS9j8hvNLTV8PeqJ16KaVEjb5PVdYgAQUFUcCG", \
  "/dns/tasty.calamari.systems/tcp/30333/p2p/12D3KooWGs2hfnRQ3Y2eAoUyWKUL3g7Jmcsf8FpyhVYeNpXeBMSu", \
  "/dns/tender.calamari.systems/tcp/30333/p2p/12D3KooWNXZeUSEKRPsp1yiDH99qSVawQSWHqG4umPjgHsn1joci" \
]

Previously it worked fine.

But now, it failed to parse bootnodes in ENTRYPOINT. So our CI always gets error on docker image check.
Removing them, it worked.

Expose port 9945 to improve CI on checking relaychain's blocks.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (manta or dolphin) with right title (start with [Manta] or [Dolphin]),
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests.
  • Updated relevant documentation in the code.
  • Added one line describing your change in <branch>/CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. If this number is updated, then the spec_version must also be updated
  • If needed, notify the committer this is a draft-release and a tag is needed after merging the PR.
  • Verify benchmarks & weights have been updated for any modified runtime logics
  • If needed, bump version for every crate.
  • If import a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are offcially used by exchanges or community developers.
  • If we're going to issue a new release, freeze the code one week early(it depends, but usually it's one week), ensure we have enough time for related testing.
  • Check if inheriting any upstream runtime storage migrations. If any, perform tests with try-runtime.

Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping Dengjianping self-assigned this Mar 8, 2022
@Dengjianping Dengjianping mentioned this pull request Mar 8, 2022
14 tasks
Copy link
Contributor

@ghzlatarev ghzlatarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this workaround, if no one can find a solution.

@Dengjianping
Copy link
Contributor Author

I think we should move bootnodes to genesis. It's not that convenient for node runners who have to append bootnodes while a node is started.

@Dengjianping
Copy link
Contributor Author

I built image with the new genesis, it works fine, and can sync blocks from mainnet.
bootNodes doesn't affect the sha of genesis.

@Dengjianping Dengjianping mentioned this pull request Mar 8, 2022
14 tasks
Dengjianping and others added 5 commits March 9, 2022 16:34
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: ghzlatarev <ghzlatarev@gmail.com>
@ghzlatarev ghzlatarev force-pushed the jamie/mv-bootnodes-to-genesis branch from c646100 to 3fca832 Compare March 9, 2022 11:48
Signed-off-by: ghzlatarev <ghzlatarev@gmail.com>
@ghzlatarev ghzlatarev force-pushed the jamie/mv-bootnodes-to-genesis branch from 368ceb8 to 700ce04 Compare March 9, 2022 13:13
Signed-off-by: ghzlatarev <ghzlatarev@gmail.com>
Copy link
Contributor

@grenade grenade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@grenade
Copy link
Contributor

grenade commented Mar 10, 2022

the hotdog node key is actually 12D3KooWBdto53HnArmLdtf2RXzNWti7hD5mML7DWGZPD8q4cywv

Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping Dengjianping changed the title Move bootnodes to calamari genesis Expose 9945 for checking relaychain's block number on parachain Mar 11, 2022
@ghzlatarev ghzlatarev self-requested a review March 11, 2022 12:30
@Dengjianping Dengjianping merged commit bd963f0 into manta Mar 11, 2022
@Dengjianping Dengjianping deleted the jamie/mv-bootnodes-to-genesis branch March 11, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants