Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark cumulus-pallet-xcmp-queue and white list Treasury Account in benchmark test #554

Merged
merged 6 commits into from
Jun 7, 2022

Conversation

Dengjianping
Copy link
Contributor

@Dengjianping Dengjianping commented May 17, 2022

Signed-off-by: Dengjianping djptux@gmail.com

Closes #537

Have to wait #481 to be merged.

Previously, we didn't include pallet-treasury, so this storage was not in this white list.
But now calamari-runtime has included this pallet, https://github.com/paritytech/polkadot/blob/master/runtime/kusama/src/lib.rs#L2188

Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping Dengjianping self-assigned this May 17, 2022
@Dengjianping Dengjianping added the A-ci Area: Continuous Integration label May 17, 2022
@Dengjianping Dengjianping added this to the v3.1.6 milestone May 17, 2022
@stechu
Copy link
Collaborator

stechu commented Jun 3, 2022

@Dengjianping How is this PR going? Still ready to schedule in 3.2.0?

@Dengjianping
Copy link
Contributor Author

Dengjianping commented Jun 4, 2022

Yes, we have to benchmark this pallet.

Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping Dengjianping marked this pull request as ready for review June 6, 2022 06:54
@Dengjianping Dengjianping requested review from stechu and Garandor June 6, 2022 07:07
ghzlatarev
ghzlatarev previously approved these changes Jun 6, 2022
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping Dengjianping mentioned this pull request Jun 6, 2022
10 tasks
@ghzlatarev ghzlatarev self-requested a review June 6, 2022 15:53
Copy link
Contributor

@Garandor Garandor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the PR title and description so the hidden change is clearly stated.
Otherwise LGTM!

runtime/calamari/src/lib.rs Show resolved Hide resolved
runtime/dolphin/src/lib.rs Show resolved Hide resolved
@Dengjianping
Copy link
Contributor Author

Please change the PR title and description so the hidden change is clearly stated. Otherwise LGTM!

Sorry, I just forgot to update it.

@Dengjianping Dengjianping changed the title Benchmark cumulus-pallet-xcmp-queue Benchmark cumulus-pallet-xcmp-queue and white list Treasury Account in benchmark test Jun 7, 2022
@Dengjianping Dengjianping merged commit 7b421ba into manta Jun 7, 2022
@Dengjianping Dengjianping deleted the jamie/benchmark-cumulus-pallet-xcmp-queue branch June 7, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Benchmark cumulus_pallet_xcmp_queue
4 participants