Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move to new eclair-v0 constructions/patterns #126

Merged
merged 8 commits into from
Jun 24, 2022
Merged

feat: move to new eclair-v0 constructions/patterns #126

merged 8 commits into from
Jun 24, 2022

Conversation

bhgomes
Copy link
Contributor

@bhgomes bhgomes commented Jun 21, 2022 •
edited
Loading

Signed-off-by: Brandon H. Gomes bhgomes@pm.me

Adds ECLAIR scaffolding and removes old compiler usage patterns throughout the manta-crypto codebase (and its descendants).

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@bhgomes
feat: move to new eclair v0 constructions/patterns
3bcd7dc 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes requested review from BoyuanFeng and tsunrise June 21, 2022 20:54
@bhgomes bhgomes changed the title feat: move to new eclair v0 constructions/patterns feat: move to new eclair-v0 constructions/patterns Jun 21, 2022
@bhgomes bhgomes added changelog:added Changelog: add these changes to the `added` section of the changelog norelease labels Jun 21, 2022
@bhgomes bhgomes added this to the v0.5.2 milestone Jun 21, 2022
bhgomes added 2 commits June 21, 2022 17:00
@bhgomes
chore: add CHANGELOG entry
df2c92d 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
fix: use for_proofs compiler for preprocessed scalar mul test
1f80e36 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes mentioned this pull request Jun 21, 2022
Merged
4 tasks
BoyuanFeng
BoyuanFeng suggested changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@BoyuanFeng BoyuanFeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I only have a few minor comments.

manta-crypto/src/eclair/alloc.rs Outdated Show resolved Hide resolved
manta-crypto/src/eclair/alloc.rs Outdated Show resolved Hide resolved
manta-crypto/src/eclair/alloc.rs Outdated Show resolved Hide resolved
manta-crypto/src/eclair/alloc.rs Outdated Show resolved Hide resolved
manta-crypto/src/eclair/cmp.rs Outdated Show resolved Hide resolved
manta-pay/src/test/payment.rs Show resolved Hide resolved
manta-pay/src/test/payment.rs Show resolved Hide resolved
manta-crypto/src/eclair/execution.rs Outdated Show resolved Hide resolved
@bhgomes
fix: address review comments
8be868f 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
tsunrise
tsunrise suggested changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@tsunrise tsunrise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, minor comments

manta-pay/src/crypto/constraint/arkworks/mod.rs Show resolved Hide resolved
manta-crypto/src/constraint.rs Outdated Show resolved Hide resolved
manta-crypto/src/hash.rs Show resolved Hide resolved
@bhgomes
fix: remove unused imports for merkle tree in test
ed38f6e 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
BoyuanFeng
BoyuanFeng previously approved these changes Jun 23, 2022
View reviewed changes
@bhgomes
fix: improve grammar for Count docs
b07e150 
Co-authored-by: Tom Shen <me@tomshen.io>

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes requested review from tsunrise and BoyuanFeng June 23, 2022 19:02
tsunrise
tsunrise previously approved these changes Jun 23, 2022
View reviewed changes
@bhgomes
Merge branch 'main' into feat/eclair-v0
238a4a5 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@BoyuanFeng BoyuanFeng requested a review from tsunrise June 24, 2022 14:54
@bhgomes bhgomes merged commit 2871cda into main Jun 24, 2022
@bhgomes bhgomes deleted the feat/eclair-v0 branch June 24, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoyuanFeng BoyuanFeng BoyuanFeng approved these changes

@tsunrise tsunrise tsunrise approved these changes

Assignees
No one assigned
Labels
changelog:added Changelog: add these changes to the `added` section of the changelog
Projects
None yet
Milestone
v0.5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@bhgomes @tsunrise @BoyuanFeng