Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: mds security hardcoded test #130

Merged
merged 5 commits into from
Jun 23, 2022
Merged

feat: mds security hardcoded test #130

merged 5 commits into from
Jun 23, 2022

Conversation

tsunrise
Copy link
Contributor

@tsunrise tsunrise commented Jun 22, 2022 •
edited by BoyuanFeng
Loading

Add hardcoded security tests for MDS matrices.

This PR adds hardcoded tests to ensure our MDS matrices pass 3 security tests in https://extgit.iaik.tugraz.at/krypto/hadeshash/-/blob/master/code/generate_parameters_grain.sage#L196-315

Closes: #111

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@tsunrise tsunrise added this to the v0.5.3 milestone Jun 22, 2022
@BoyuanFeng BoyuanFeng added the changelog:added Changelog: add these changes to the `added` section of the changelog label Jun 22, 2022
@BoyuanFeng BoyuanFeng marked this pull request as ready for review June 23, 2022 04:49
@BoyuanFeng BoyuanFeng requested a review from bhgomes June 23, 2022 14:24
bhgomes
bhgomes suggested changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@bhgomes bhgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some unused variables.

manta-pay/src/crypto/hash/poseidon/mds_hardcoded_tests/correct_mds_generation.sage Outdated Show resolved Hide resolved
manta-pay/src/crypto/hash/poseidon/mds_hardcoded_tests/correct_mds_generation.sage Outdated Show resolved Hide resolved
@bhgomes bhgomes requested a review from BoyuanFeng June 23, 2022 19:13
bhgomes
bhgomes previously approved these changes Jun 23, 2022
View reviewed changes
BoyuanFeng
BoyuanFeng previously approved these changes Jun 23, 2022
View reviewed changes
@tsunrise tsunrise modified the milestones: v0.5.3, v0.5.2 Jun 23, 2022
@tsunrise
Merge branch 'main' into feat/mds_security
03cf628 
Signed-off-by: Tom Shen <me@tomshen.io>
@tsunrise tsunrise dismissed stale reviews from BoyuanFeng and bhgomes via 03cf628 June 23, 2022 19:59
@tsunrise tsunrise requested review from bhgomes and BoyuanFeng June 23, 2022 19:59
@tsunrise tsunrise merged commit f64bcaf into main Jun 23, 2022
@tsunrise tsunrise deleted the feat/mds_security branch June 23, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoyuanFeng BoyuanFeng BoyuanFeng approved these changes

@bhgomes bhgomes bhgomes approved these changes

Assignees

@tsunrise tsunrise

@BoyuanFeng BoyuanFeng

Labels
changelog:added Changelog: add these changes to the `added` section of the changelog
Projects
None yet
Milestone
v0.5.2
Development

Successfully merging this pull request may close these issues.

Add MDS matrix testing for security
3 participants
@tsunrise @bhgomes @BoyuanFeng