Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add signature scheme abstraction #134

Merged
merged 4 commits into from
Jun 28, 2022
Merged

feat: add signature scheme abstraction #134

merged 4 commits into from
Jun 28, 2022

Conversation

bhgomes
Copy link
Contributor

@bhgomes bhgomes commented Jun 27, 2022

  • Adds signature module with APIs for signature schemes with correctness test
  • Adds schnorr module with implementation of Schnorr signatures
  • Adds security properties for hash functions

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@bhgomes bhgomes self-assigned this Jun 27, 2022
@bhgomes bhgomes added this to the v0.5.2 milestone Jun 27, 2022
@bhgomes bhgomes added changelog:added Changelog: add these changes to the `added` section of the changelog norelease labels Jun 27, 2022
@tsunrise tsunrise self-requested a review June 27, 2022 18:52
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes marked this pull request as ready for review June 27, 2022 19:00
@bhgomes bhgomes requested a review from BoyuanFeng June 27, 2022 19:00
manta-crypto/src/signature.rs Show resolved Hide resolved
manta-crypto/src/signature.rs Show resolved Hide resolved
@bhgomes bhgomes merged commit e8ea531 into main Jun 28, 2022
@bhgomes bhgomes deleted the feat/signature-scheme branch June 28, 2022 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:added Changelog: add these changes to the `added` section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants