Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce complexity by splitting transfer into parts #151

Merged
merged 6 commits into from
Jul 5, 2022

Conversation

bhgomes
Copy link
Contributor

@bhgomes bhgomes commented Jul 1, 2022

Split the Sender and Receiver logic out of the transfer module into new sender and receiver modules.

NOTE: The CHANGELOG entry is marked as changelog:fixed since it refers to an internal structural change that does not change any interfaces (changelog:changed) and does not add any interfaces (changelog:added).


Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@bhgomes bhgomes added changelog:fixed Changelog: add these changes to the `fixed` section of the changelog norelease labels Jul 4, 2022
@bhgomes bhgomes marked this pull request as ready for review July 4, 2022 17:24
@bhgomes bhgomes added this to the v0.6.0 milestone Jul 4, 2022
@BoyuanFeng BoyuanFeng self-requested a review July 5, 2022 03:37
@bhgomes bhgomes requested review from tsunrise and GhostOfGauss July 5, 2022 13:39
@bhgomes bhgomes modified the milestones: v0.6.0, v0.5.3 Jul 5, 2022
@bhgomes bhgomes merged commit 07bc1ab into main Jul 5, 2022
@bhgomes bhgomes deleted the fix/split-transfer-module branch July 5, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:fixed Changelog: add these changes to the `fixed` section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants