Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add more pre-check to the CI #152

Merged
merged 4 commits into from
Jul 5, 2022
Merged

feat: add more pre-check to the CI #152

merged 4 commits into from
Jul 5, 2022

Conversation

bhgomes
Copy link
Contributor

@bhgomes bhgomes commented Jul 3, 2022 •
edited
Loading

Adds workspace-hack-check and docs as pre-checks for the rest of the CI pipeline.

Screen Shot 2022-07-03 at 20 37 57

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@bhgomes bhgomes added changelog:added Changelog: add these changes to the `added` section of the changelog norelease labels Jul 3, 2022
@bhgomes bhgomes added this to the v0.5.3 milestone Jul 3, 2022
@bhgomes bhgomes marked this pull request as ready for review July 4, 2022 00:04
@bhgomes bhgomes added changelog:changed Changelog: add these changes to the `changed` section of the changelog and removed changelog:added Changelog: add these changes to the `added` section of the changelog labels Jul 4, 2022
@bhgomes bhgomes requested review from BoyuanFeng and tsunrise July 4, 2022 00:37
BoyuanFeng
BoyuanFeng suggested changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@BoyuanFeng BoyuanFeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor issue on CHANGELOG.

Do we have any profiling on the compilation speedup from cargo hakari?

CHANGELOG.md Outdated Show resolved Hide resolved
@bhgomes
chore: update CHANGELOG grammar
4713810 
Co-authored-by: Boyuan Feng <bfeng9@wisc.edu>

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes requested a review from BoyuanFeng July 5, 2022 13:58
@bhgomes
Copy link
Contributor Author

bhgomes commented Jul 5, 2022 •
edited
Loading

One minor issue on CHANGELOG.

Do we have any profiling on the compilation speedup from cargo hakari?

Due to all the upgrades, it goes from 45min-65min down to about 35min-40min.

@bhgomes bhgomes requested a review from GhostOfGauss July 5, 2022 15:09
@bhgomes bhgomes merged commit 4dea617 into main Jul 5, 2022
@bhgomes bhgomes deleted the feat/more-pre-check-ci branch July 5, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoyuanFeng BoyuanFeng BoyuanFeng approved these changes

@tsunrise tsunrise tsunrise approved these changes

@GhostOfGauss GhostOfGauss Awaiting requested review from GhostOfGauss

Assignees
No one assigned
Labels
changelog:changed Changelog: add these changes to the `changed` section of the changelog
Projects
None yet
Milestone
v0.5.3
Development

Successfully merging this pull request may close these issues.
3 participants
@bhgomes @tsunrise @BoyuanFeng