Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trusted Setup Phase 2 #172

Merged
merged 61 commits into from
Jul 29, 2022
Merged

Trusted Setup Phase 2 #172

merged 61 commits into from
Jul 29, 2022

Conversation

BoyuanFeng
Copy link
Contributor

@BoyuanFeng BoyuanFeng commented Jul 15, 2022 •
edited
Loading

  • Sanity checks against Todd's code
  • Refactor to new MPC model.
  • See if I can use the sample trait from Crypto.
  • Code clean such as removing comments & inline some functions.
  • Update the dependency order.
  • Refactor serialize.
  • Add HashToGroup trait.

Closes: #120

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@BoyuanFeng BoyuanFeng marked this pull request as draft July 15, 2022 18:58
@tsunrise tsunrise added changelog:added Changelog: add these changes to the `added` section of the changelog C-enhancement Category: An issue proposing an enhancement or a PR with one A-cryptography Area: Issues and PRs related to Cryptography labels Jul 15, 2022
@bhgomes bhgomes added the A-trusted-setup Area: Issues and PRs related to Trusted Setup label Jul 15, 2022
@bhgomes bhgomes added this to the v0.6.0 milestone Jul 19, 2022
Boyuan Feng and others added 2 commits July 27, 2022 18:41
bhgomes
bhgomes suggested changes Jul 28, 2022
View reviewed changes
manta-trusted-setup/src/groth16/test.rs Outdated Show resolved Hide resolved
manta-trusted-setup/src/groth16/test.rs Outdated Show resolved Hide resolved
manta-trusted-setup/src/groth16/test.rs Outdated Show resolved Hide resolved
manta-trusted-setup/src/groth16/test.rs Outdated Show resolved Hide resolved
manta-trusted-setup/src/groth16/test.rs Outdated Show resolved Hide resolved
manta-trusted-setup/src/groth16/test.rs Outdated Show resolved Hide resolved
manta-trusted-setup/src/ratio.rs Outdated Show resolved Hide resolved
bhgomes and others added 11 commits July 28, 2022 03:18
@bhgomes bhgomes requested review from GhostOfGauss and bhgomes July 29, 2022 00:06
bhgomes
bhgomes previously approved these changes Jul 29, 2022
View reviewed changes
@bhgomes
fix: don't depend on workspace-hack-check for other CI
dc58951 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
bhgomes
bhgomes previously approved these changes Jul 29, 2022
View reviewed changes
GhostOfGauss
GhostOfGauss previously approved these changes Jul 29, 2022
View reviewed changes
manta-trusted-setup/src/ratio.rs Outdated Show resolved Hide resolved
manta-trusted-setup/src/ratio.rs Outdated Show resolved Hide resolved
manta-trusted-setup/src/ratio.rs Show resolved Hide resolved
manta-trusted-setup/src/pairing.rs Show resolved Hide resolved
@BoyuanFeng BoyuanFeng dismissed stale reviews from GhostOfGauss and bhgomes via 4e85bab July 29, 2022 16:01
bhgomes
bhgomes suggested changes Jul 29, 2022
View reviewed changes
manta-trusted-setup/src/groth16/mpc.rs Outdated Show resolved Hide resolved
manta-trusted-setup/src/groth16/mpc.rs Outdated Show resolved Hide resolved
manta-trusted-setup/src/groth16/mpc.rs Outdated Show resolved Hide resolved
manta-trusted-setup/src/pairing.rs Outdated Show resolved Hide resolved
manta-trusted-setup/src/util.rs Outdated Show resolved Hide resolved
@BoyuanFeng BoyuanFeng merged commit df6b214 into main Jul 29, 2022
@BoyuanFeng BoyuanFeng deleted the feat/phase2 branch July 29, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsunrise tsunrise tsunrise approved these changes

@bhgomes bhgomes bhgomes approved these changes

@GhostOfGauss GhostOfGauss GhostOfGauss left review comments

Assignees

@tsunrise tsunrise

@BoyuanFeng BoyuanFeng

@GhostOfGauss GhostOfGauss

Labels
A-cryptography Area: Issues and PRs related to Cryptography A-trusted-setup Area: Issues and PRs related to Trusted Setup C-enhancement Category: An issue proposing an enhancement or a PR with one changelog:added Changelog: add these changes to the `added` section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Phase2 Arkworks Interface
4 participants
@BoyuanFeng @bhgomes @tsunrise @GhostOfGauss