-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade manta-crypto abstractions for new circuits #176
Conversation
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this great PR! Two minor comments:
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems alright since the last review. Just one question to see if I understand correctly what's going on in the last commit. Is it that you are now required to explicitly mention the generic lifetime (even if you don't actually use it, hence the underscore) because of the new nightly released, and no actual change to the code happened?
Yeah, it seems the current version of nightly Rust requires explicit lifetimes in some places where it used to be implicit. Not sure why this change has been introduced though, but we had to patch it here. |
Derived
allocation mode to arbitrary type flagsTypes
traitItemHashFunction
for explicit "leaf hash" constructions for general accumulators (withItemHashAccumulatorModel
andItemHashAccumulator
wrappers)MembershipProof
toDerived
modeassert_equal
toPartialEq
to lift efficient assertion implementations to theAssertEq
traitNonNative
marker trait to allow distinguishing()
from non-native compilers (this allows(): Has<T>
)Zero
andOne
traitsPartialEq
implementations for compound typesCheckedAdd
andCheckedSub
traits to numeric utilitiesall_unequal
utility functionBefore we can merge this PR, please make sure that all the following items have been checked off:
CHANGELOG.md
and added the appropriatechangelog
label to the PR.Files changed
in the GitHub PR explorer.CONTRIBUTING.md
.