Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add .gitignore and README.md support to manta-parameters #220

Merged
merged 2 commits into from
Aug 26, 2022

Conversation

bhgomes
Copy link
Contributor

@bhgomes bhgomes commented Aug 26, 2022

Signed-off-by: Brandon H. Gomes bhgomes@pm.me

Adds .gitignore support for manta-parameters. Files can now be added to the data directory without requiring them to be uploaded to GitHub by specifying them in a .gitignore file local to any of the subdirectories of the data directory. In this case, a README.md should be used to direct users to download the ignored files from an external service.


Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.
  • Ran cargo hakari generate to update the workspace-hack system

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes changed the title feat: add .gitignore support to manta-parameters feat: add .gitignore and README.md support to manta-parameters Aug 26, 2022
@bhgomes bhgomes added the changelog:fixed Changelog: add these changes to the `fixed` section of the changelog label Aug 26, 2022
@bhgomes bhgomes added this to the v0.5.5 milestone Aug 26, 2022
@bhgomes bhgomes self-assigned this Aug 26, 2022
@bhgomes bhgomes requested a review from BoyuanFeng August 26, 2022 00:08
@bhgomes bhgomes marked this pull request as ready for review August 26, 2022 00:09
@bhgomes bhgomes added the A-development Area: Development Resources and Upgrades label Aug 26, 2022
Copy link
Contributor

@SupremoUGH SupremoUGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all seems fine, but have you checked that it works with an actual file?

@bhgomes
Copy link
Contributor Author

bhgomes commented Aug 26, 2022

It all seems fine, but have you checked that it works with an actual file?

Yes, I've checked it. @GhostOfGauss you should also check that it matches your workflow to make sure that these changes make sense.

Copy link
Contributor

@GhostOfGauss GhostOfGauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@bhgomes bhgomes merged commit c661362 into main Aug 26, 2022
@bhgomes bhgomes deleted the fix/simplify-parameter-parsing branch August 26, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-development Area: Development Resources and Upgrades changelog:fixed Changelog: add these changes to the `fixed` section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants