Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Move Ratio Proof #236

Merged
merged 6 commits into from
Sep 2, 2022
Merged

Chore: Move Ratio Proof #236

merged 6 commits into from
Sep 2, 2022

Conversation

SupremoUGH
Copy link
Contributor

@SupremoUGH SupremoUGH commented Aug 31, 2022 •
edited by bhgomes
Loading

Moved ratio.rs with the RatioProof primitive from manta-trusted-setup to manta-crypto.

Closes #189

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@SupremoUGH
moved ratio
cb2991f
@SupremoUGH
ratio
015f278
@SupremoUGH
ratio.rs moved from manta-trusted-setup to manta-crypto
89ef0df 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
changelog
e79ce47 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH SupremoUGH added the changelog:changed Changelog: add these changes to the `changed` section of the changelog label Aug 31, 2022
@SupremoUGH SupremoUGH self-assigned this Aug 31, 2022
@SupremoUGH SupremoUGH marked this pull request as ready for review August 31, 2022 16:26
@SupremoUGH SupremoUGH added P-low Priority: Low C-cleanup Category: Issues documenting cleanup or PRs that clean code up A-cryptography Area: Issues and PRs related to Cryptography labels Aug 31, 2022
bhgomes
bhgomes previously approved these changes Aug 31, 2022
View reviewed changes
@SupremoUGH SupremoUGH requested a review from bhgomes August 31, 2022 18:10
bhgomes
bhgomes previously approved these changes Aug 31, 2022
View reviewed changes
BoyuanFeng
BoyuanFeng previously approved these changes Aug 31, 2022
View reviewed changes
@SupremoUGH
Move ratio import in hashing.rs
46848f0 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH SupremoUGH dismissed stale reviews from BoyuanFeng and bhgomes via 46848f0 August 31, 2022 18:42
@SupremoUGH SupremoUGH merged commit 0e5b93e into main Sep 2, 2022
@SupremoUGH SupremoUGH deleted the chore/move_ratio_proof branch September 2, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoyuanFeng BoyuanFeng BoyuanFeng approved these changes

@bhgomes bhgomes bhgomes approved these changes

@tsunrise tsunrise Awaiting requested review from tsunrise

@GhostOfGauss GhostOfGauss Awaiting requested review from GhostOfGauss

Assignees

@SupremoUGH SupremoUGH

Labels
A-cryptography Area: Issues and PRs related to Cryptography C-cleanup Category: Issues documenting cleanup or PRs that clean code up changelog:changed Changelog: add these changes to the `changed` section of the changelog P-low Priority: Low
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Cryptographic Primitives out of manta-trusted-setup
3 participants
@SupremoUGH @bhgomes @BoyuanFeng