Move `Fp` and `R1CS` to `manta-crypto` #248

GhostOfGauss · 2022-09-08T22:19:47Z

Moves Fp and partially moves R1CS to manta-crypto as part of #40

This copies manta_pay::crypto::constraint::arkworks::codec into manta-crypto without removing it from manta-pay because it is still referenced by too many other parts of manta-pay. It will be removed in a future PR.

This removes scale entirely from manta-pay, its functionality is to be replaced in a way that @bhgomes can explain.

This finishes copying some R1CS impl's that weren't included in #180 but does not remove R1CS from manta-pay yet due to this being referenced by too much groth16 related code. R1CS will be removed from manta-pay together with groth16 in a future PR.

Before we can merge this PR, please make sure that all the following items have been checked off:

Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
Re-reviewed Files changed in the GitHub PR explorer.
Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

SupremoUGH

Everything seems fine, even though I don't fully understand (de)serialization, so please double check the details of that with Brandon.

SupremoUGH · 2022-09-12T19:28:25Z

manta-crypto/src/arkworks/codec.rs

+
+    /// Updates the internal reader state by performing the `f` computation.
+    #[inline]
+    fn update<T, F>(&mut self, f: F) -> Option<T>


why do we want this fn to be private?

bhgomes · 2022-09-14T09:46:52Z

manta-crypto/src/arkworks/codec.rs

+// You should have received a copy of the GNU General Public License
+// along with manta-rs.  If not, see <http://www.gnu.org/licenses/>.
+
+//! Codec Utilities


The stuff in this file can go in arkworks::serialize instead, we don't need to split this out.

bhgomes · 2022-09-14T09:48:20Z

manta-crypto/src/arkworks/mod.rs

@@ -34,6 +34,7 @@ pub use ark_ed_on_bls12_381 as ed_on_bls12_381;
 pub use ark_ed_on_bn254 as ed_on_bn254;

 pub mod algebra;
+pub mod codec;


Like I mentioned before, we can use serialize here instead and do an extension of ark-serialize in that module.

bhgomes · 2022-09-14T09:49:00Z

manta-pay/src/config.rs

@@ -17,7 +17,7 @@
 //! Manta-Pay Configuration

 use crate::crypto::{
-    constraint::arkworks::{field_element_as_bytes, groth16, Boolean, Fp, FpVar, R1CS},
+    constraint::arkworks::{groth16, Boolean, R1CS}, // TODO: Move R1CS with Groth16


fix todo item or leave it out of here (use GH issue to track this)

bhgomes · 2022-09-14T09:49:37Z

manta-pay/src/crypto/constraint/arkworks/groth16.rs

@@ -19,7 +19,7 @@
 use crate::crypto::constraint::arkworks::{
    self,
    codec::{HasDeserialization, HasSerialization, SerializationError},
-    R1CS,
+    R1CS, // TODO: Move with Groth16


same as above TODO

bhgomes · 2022-09-14T09:50:05Z

manta-pay/src/crypto/constraint/arkworks/mod.rs

@@ -757,12 +451,13 @@ where
 /// Testing Suite
 #[cfg(test)]
 mod tests {
+    // TODO: move to constraint with R1CS


same as other TODO

bhgomes · 2022-09-14T09:50:15Z

manta-pay/src/crypto/ecc/arkworks.rs

+    empty,
+    full,
+    Boolean,
+    R1CS, // TODO: Move R1CS with Groth16


same as other TODO

bhgomes · 2022-09-14T09:51:34Z

manta-crypto/Cargo.toml

@@ -32,6 +32,7 @@ arkworks = [
    "ark-r1cs-std",
    "ark-relations",
    "ark-serialize",
+    "ark-std",


in this case, cause we need it, lets re-export it too

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

bhgomes · 2022-11-18T20:20:11Z

Replaced by #284

GhostOfGauss added 3 commits September 8, 2022 19:30

wip: remove all scale dep

316b996

migrate Fp

3bb5ec5

move r1cs to manta-crypto

bb0a7e6

GhostOfGauss added A-cryptography Area: Issues and PRs related to Cryptography A-openzl Area: Development Related to OpenZL and ECLAIR labels Sep 8, 2022

GhostOfGauss self-assigned this Sep 8, 2022

GhostOfGauss added 8 commits September 9, 2022 00:36

remove unused imports

7fc06f1

fix dep.s for tests

382b461

fix: changelog

8e4b4e5

merge 'main' into 'feat/move_fp'

3b4e37c

wip: move R1CS

d1a1a40

fmt

4ef56d6

feat: finish moving FpVar out of manta-pay

f6fe9ca

remove comments

a982d32

GhostOfGauss requested review from bhgomes and SupremoUGH September 12, 2022 19:08

GhostOfGauss marked this pull request as ready for review September 12, 2022 19:08

SupremoUGH previously approved these changes Sep 12, 2022

View reviewed changes

bhgomes suggested changes Sep 14, 2022

View reviewed changes

bhgomes added the P-medium Priority: Medium label Sep 20, 2022

Merge branch 'main' into feat/move_fp

f22aaec

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

bhgomes dismissed SupremoUGH’s stale review via f22aaec October 3, 2022 14:23

bhgomes closed this Nov 18, 2022

bhgomes deleted the feat/move_fp branch November 18, 2022 20:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move `Fp` and `R1CS` to `manta-crypto` #248

Move `Fp` and `R1CS` to `manta-crypto` #248

GhostOfGauss commented Sep 8, 2022 •

edited

Loading

SupremoUGH left a comment

SupremoUGH Sep 12, 2022

bhgomes Sep 14, 2022

bhgomes Sep 14, 2022

bhgomes Sep 14, 2022

bhgomes Sep 14, 2022

bhgomes Sep 14, 2022

bhgomes Sep 14, 2022

bhgomes Sep 14, 2022

bhgomes commented Nov 18, 2022

Move Fp and R1CS to manta-crypto #248

Move Fp and R1CS to manta-crypto #248

Conversation

GhostOfGauss commented Sep 8, 2022 • edited Loading

SupremoUGH left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bhgomes commented Nov 18, 2022

Move `Fp` and `R1CS` to `manta-crypto` #248

Move `Fp` and `R1CS` to `manta-crypto` #248

GhostOfGauss commented Sep 8, 2022 •

edited

Loading