Signer redesign features #262

AlexParshh · 2022-10-01T04:12:41Z

This PR contains new features which enable the signer native app to operate on multiple networks and export/recover accounts using a mnemonic seed phrase.

Before we can merge this PR, please make sure that all the following items have been checked off:

Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
Re-reviewed Files changed in the GitHub PR explorer.
Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

Co-authored-by: Brandon H. Gomes <bhgomes@pm.me> Signed-off-by: Alexander Parsh <53206800+AlexParshh@users.noreply.github.com>

…anta-rs into mnemonic_storage code review

manta-accounting/src/wallet/mod.rs

manta-accounting/src/wallet/signer.rs

…nta-rs into signer_redesign

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

manta-pay/src/signer/client/mod.rs

manta-pay/src/signer/client/network.rs

Co-authored-by: Brandon H. Gomes <bhgomes@pm.me> Signed-off-by: Alexander Parsh <53206800+AlexParshh@users.noreply.github.com>

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

AlexParshh and others added 30 commits September 27, 2022 20:41

adding mnemonic to KeySecret

7745319

bug

a2e676d

bug again

8cb6c2b

build error

85e9e7f

another bug

8eb4f9c

sample error

145e9f9

bug

097bd04

getter for base from Map

e64aa76

make expose_mnemonic public

4d6274f

Update manta-accounting/src/key.rs

e65fdbe

Co-authored-by: Brandon H. Gomes <bhgomes@pm.me> Signed-off-by: Alexander Parsh <53206800+AlexParshh@users.noreply.github.com>

Update manta-accounting/src/wallet/signer.rs

5cf9b22

Co-authored-by: Brandon H. Gomes <bhgomes@pm.me> Signed-off-by: Alexander Parsh <53206800+AlexParshh@users.noreply.github.com>

code review changes

3eff3fa

Merge branch 'mnemonic_storage' of https://github.com/Manta-Network/m…

c82a7ae

…anta-rs into mnemonic_storage code review

remove idea

5500d10

cargo format

2f184f7

build fix

1d7cf64

added NetworkType to SignRequest

8a52779

added network to transaction display function

d6beabc

added mint display

ad8a106

added networkType for post

c244cff

string error

b1fbb48

import string

8f79569

multiple networks sync

20f465e

compile errors

00c2234

compile errors

0fcb04c

added signer busy error

ffaa142

cargo fmt

0007452

build fix

8e04e30

fmt

691de20

documentation

8a8511a

bhgomes suggested changes Oct 29, 2022

View reviewed changes

manta-accounting/src/wallet/mod.rs Outdated Show resolved Hide resolved

manta-accounting/src/wallet/signer.rs Outdated Show resolved Hide resolved

AlexParshh and others added 13 commits October 31, 2022 21:14

fix: move Network type into manta-pay

0a226ae

Merge branch 'signer_redesign' of https://github.com/Manta-Network/ma…

8b93c2f

…nta-rs into signer_redesign

fix: pr comments

3206a4d

fix: network cfg

b631bbd

fix: feature

2e8d6ba

replace tiny-bip39 with bip0039 crate

20030d0

another attempt to derive same zkAddress

5bdbfc7

fmt

3a97180

Merge branch 'main' into signer_redesign

a15e487

fix: sort dependencies

9521627

Merge branch 'signer_redesign' of https://github.com/Manta-Network/ma…

966c3f8

…nta-rs into signer_redesign

changelog

57e08af

Merge branch 'main' into signer_redesign

5df8848

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

AlexParshh added the changelog:added Changelog: add these changes to the `added` section of the changelog label Nov 3, 2022

bhgomes suggested changes Nov 3, 2022

View reviewed changes

bhgomes requested a review from Kevingislason November 3, 2022 18:10

AlexParshh and others added 5 commits November 3, 2022 14:34

Update manta-pay/src/signer/client/mod.rs

611bae3

Co-authored-by: Brandon H. Gomes <bhgomes@pm.me> Signed-off-by: Alexander Parsh <53206800+AlexParshh@users.noreply.github.com>

Update manta-pay/src/signer/client/network.rs

b3c446b

Co-authored-by: Brandon H. Gomes <bhgomes@pm.me> Signed-off-by: Alexander Parsh <53206800+AlexParshh@users.noreply.github.com>

Update manta-pay/src/signer/client/network.rs

23ce93f

Co-authored-by: Brandon H. Gomes <bhgomes@pm.me> Signed-off-by: Alexander Parsh <53206800+AlexParshh@users.noreply.github.com>

Update manta-pay/src/signer/client/network.rs

e024094

Co-authored-by: Brandon H. Gomes <bhgomes@pm.me> Signed-off-by: Alexander Parsh <53206800+AlexParshh@users.noreply.github.com>

Update manta-pay/src/signer/client/network.rs

373131e

Co-authored-by: Brandon H. Gomes <bhgomes@pm.me> Signed-off-by: Alexander Parsh <53206800+AlexParshh@users.noreply.github.com>

Kevingislason previously approved these changes Nov 3, 2022

View reviewed changes

chore: fix import position

8054256

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

bhgomes dismissed Kevingislason’s stale review via 8054256 November 4, 2022 15:45

bhgomes approved these changes Nov 4, 2022

View reviewed changes

bhgomes requested a review from Kevingislason November 4, 2022 16:20

Kevingislason approved these changes Nov 4, 2022

View reviewed changes

bhgomes merged commit ab8657c into main Nov 4, 2022

bhgomes deleted the signer_redesign branch November 4, 2022 22:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Signer redesign features #262

Signer redesign features #262

AlexParshh commented Oct 1, 2022 •

edited

Loading

Signer redesign features #262

Signer redesign features #262

Conversation

AlexParshh commented Oct 1, 2022 • edited Loading

AlexParshh commented Oct 1, 2022 •

edited

Loading