Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trusted Setup Client v2 #268

Merged
merged 13 commits into from
Oct 27, 2022
Merged

Trusted Setup Client v2 #268

merged 13 commits into from
Oct 27, 2022

Conversation

GhostOfGauss
Copy link
Contributor

@GhostOfGauss GhostOfGauss commented Oct 21, 2022

Updates the Trusted Setup Client to address two common problems:

  • Invalid signatures in registration form: this problem is caused by participants incorrectly copying the relevant information (email, twitter, verifying key, signature) to our registration form. This problem is solved by creating customized links to the registration form that automatically fill in the above fields.
  • Error message Registry update is taking longer than expected... for contribute mode was misleading. Participants commonly did not understand that they needed to wait until the ceremony begins to run the client in contribute mode. The error message is now more informative and leads them to a landing page for more information.

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@GhostOfGauss GhostOfGauss marked this pull request as ready for review October 21, 2022 18:08
SupremoUGH
SupremoUGH previously approved these changes Oct 21, 2022
Copy link
Contributor

@SupremoUGH SupremoUGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep the old messages as well? So people would get their public key + signature separately and then they have the link to the google form. Also this way we don't have to update the docs.

@GhostOfGauss
Copy link
Contributor Author

I prefer to keep the output of the client as simple as possible, so I think v2 should only display the link.

I can include a section in the docs that addresses v1 clients, but I plan to update the docs to assume v2.

@bhgomes bhgomes added the changelog:changed Changelog: add these changes to the `changed` section of the changelog label Oct 24, 2022
Copy link
Contributor

@bhgomes bhgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the screenshot can use another one with the standard window size to see the wrapping (even if you wanted to use a wide one which I don't recommend, the one you posted has one character on the next line which is easy to miss).

manta-trusted-setup/src/groth16/ceremony/mod.rs Outdated Show resolved Hide resolved
manta-trusted-setup/src/groth16/ceremony/config/ppot.rs Outdated Show resolved Hide resolved
@bhgomes bhgomes added this to the v0.5.6 milestone Oct 24, 2022
@bhgomes bhgomes merged commit 25f0a22 into main Oct 27, 2022
@bhgomes bhgomes deleted the feat/client_v2 branch October 27, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:changed Changelog: add these changes to the `changed` section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants