Feat: upgraded key system #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
SupremoUGH
added
changelog:changed
bhgomes
suggested changes
Nov 15, 2022
There was a problem hiding this comment.
We need bip0039 for the signer changes. @AlexParshh please check this PR in the key system
GhostOfGauss
previously approved these changes
Nov 16, 2022
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
GhostOfGauss
previously approved these changes
Nov 17, 2022
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
GhostOfGauss
approved these changes
Nov 18, 2022
bhgomes
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second part of #153. It consists of the changes related to the key system.
Changes:
manta-accounting:key.rs: Upgrade to the new key system. DeprecatedHierarchicalKeyDerivationSchemein favour ofAccountCollection.signer.rs: Minimal changes so it compiles.manta-pay:key.rs: Upgrade to the new system. Now we don't use key pairs, just keys.signer::base: ImplementedAccountCollectionandDeriveAddressesforKeySecret.signer: minimal changes so it compiles.Before we can merge this PR, please make sure that all the following items have been checked off:
CHANGELOG.mdand added the appropriatechangeloglabel to the PR.Files changedin the GitHub PR explorer.CONTRIBUTING.md.