-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MantaPay v1 #286
Merged
Merged
MantaPay v1 #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
SupremoUGH
added
changelog:added
Changelog: add these changes to the `added` section of the changelog
P-high
Priority: High
labels
Nov 29, 2022
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
bhgomes
reviewed
Nov 30, 2022
bhgomes
reviewed
Nov 30, 2022
bhgomes
reviewed
Nov 30, 2022
bhgomes
reviewed
Nov 30, 2022
bhgomes
reviewed
Nov 30, 2022
bhgomes
reviewed
Nov 30, 2022
Co-authored-by: Brandon H. Gomes <bhgomes@pm.me> Signed-off-by: Francisco Hernández Iglesias <38819712+SupremoUGH@users.noreply.github.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
bhgomes
previously approved these changes
Dec 1, 2022
9 tasks
GhostOfGauss
reviewed
Dec 3, 2022
GhostOfGauss
reviewed
Dec 3, 2022
Co-authored-by: Todd Norton <93260651+GhostOfGauss@users.noreply.github.com> Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
bhgomes
previously approved these changes
Dec 3, 2022
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
GhostOfGauss
approved these changes
Dec 3, 2022
bhgomes
approved these changes
Dec 3, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog:added
Changelog: add these changes to the `added` section of the changelog
P-high
Priority: High
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last part of #153. It consists of the changes related to the transfer protocol and the signer.
Changes:
manta-util
:codec.rs
:Encode
implementation formanta_util::Array
.num.rs
:CheckedAdd
implementation for references of types implementingCheckedAdd
. Same forCheckedSub
.manta-crypto
:arkworks::algebra
: movedScalarVar
,Group
, andGroupVar
and their trait implementations here.constraint
: Added division with remainder utilities.encryption
: Fixed error inConstant
implementation forUnsafeNoEncrypt
.manta-accounting
:asset.rs
: Weakened the assumptions forHashAssetMap
andBTreeAssetMap
.transfer
: Upgrade to new transfer protocol.wallet
: Upgrade signer.manta-pay
:crypto::ecc
: Deleted and moved tomanta-crypto
.crypto::poseidon::arkworks
: Fixed error inBlockElement
implementation forFpVar
.crypto::poseidon::encryption
: Fixed error inWrite
implementation forCiphertextBlock
. AddedDecode
andEncode
implementations forFixedEncryption
.crypto::poseidon
: Implementations forState
.config
: Concrete implementations oftransfer::Configuration
andprotocol::Configuration
inmod
andutxo
, respectively.signer
: Upgrade to the new signer.test
andsimulation
: new testing suite and simulation for the new protocol.manta-parameters
andmanta-pay::parameters
:manta-benchmark
:ToPrivate
,PrivateTransfer
andToPublic
proof generation and verification.TODO:
Sample
(which I might have to undo).manta-parameters
to main.manta-accounting
tomanta-pay
(if possible).Before we can merge this PR, please make sure that all the following items have been checked off:
CHANGELOG.md
and added the appropriatechangelog
label to the PR.Files changed
in the GitHub PR explorer.CONTRIBUTING.md
.