-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial signer sync #329
Merged
Merged
Initial signer sync #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SupremoUGH
added
the
changelog:added
Changelog: add these changes to the `added` section of the changelog
label
Mar 22, 2023
This was referenced Mar 22, 2023
bhgomes
suggested changes
Mar 23, 2023
Apokalip
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgmt
bhgomes
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes together with:
Implements the Initial Synchronization method for the signer. For that, there's a new method that creates a partial Merkle tree from a vector of leaves and a path, extended to forked trees and forests.
On the wallet side, we read the relevant data from the ledger and then use it to update the signer, without any Poseidon hash computation (as opposed to the usual sync method).
Design choice:
On the testing/simulation: Besides the new unit tests for the partial and forked MKs, I ran the simulation, kept the Ledger, and then re-ran it again with new actors which would do the initial sync w.r.t. the new ledger. It all went smoothly, as expected. The code was quite clumsy and it'd take a long time to make it look better (and add nice features like new actors joining the simulation at arbitrary times) so I removed that part, but it's good to know that it worked as expected.
Before we can merge this PR, please make sure that all the following items have been checked off:
CHANGELOG.md
and added the appropriatechangelog
label to the PR.Files changed
in the GitHub PR explorer.CONTRIBUTING.md
.