Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support scalar mul of arkworks curve using precomputed table #34

Merged
merged 8 commits into from
Mar 26, 2022
Merged

Support scalar mul of arkworks curve using precomputed table #34

merged 8 commits into from
Mar 26, 2022

Conversation

tsunrise
Copy link
Contributor

@tsunrise tsunrise commented Mar 8, 2022

Adds support for scalar multiplication using precomputed bases.

Closes: #24

bhgomes
bhgomes suggested changes Mar 10, 2022
View reviewed changes
manta-pay/src/crypto/ecc/arkworks.rs Outdated Show resolved Hide resolved
manta-crypto/src/ecc.rs Outdated Show resolved Hide resolved
bhgomes
bhgomes suggested changes Mar 11, 2022
View reviewed changes
manta-pay/src/crypto/ecc/arkworks.rs Outdated Show resolved Hide resolved
manta-pay/src/crypto/ecc/arkworks.rs Outdated Show resolved Hide resolved
manta-crypto/src/ecc.rs Outdated Show resolved Hide resolved
@tsunrise
Copy link
Contributor Author

Can someone allow force push on branches other than main? I messed up with commit histories @bhgomes @stechu

@tsunrise tsunrise force-pushed the scalar_mul_precomputed branch from a78e47a to 5359a0a Compare March 19, 2022 05:27
bhgomes
bhgomes suggested changes Mar 20, 2022
View reviewed changes
Copy link
Contributor

@bhgomes bhgomes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments on the implementation that should be addressed before merging, but we still need to do some more work to actually be able to use this optimization in the circuit.

manta-crypto/src/ecc.rs Outdated Show resolved Hide resolved
manta-pay/src/crypto/ecc/arkworks.rs Outdated Show resolved Hide resolved
manta-pay/src/crypto/ecc/arkworks.rs Outdated Show resolved Hide resolved
manta-pay/src/crypto/ecc/arkworks.rs Outdated Show resolved Hide resolved
manta-pay/src/crypto/ecc/arkworks.rs Outdated Show resolved Hide resolved
manta-pay/src/crypto/ecc/arkworks.rs Outdated Show resolved Hide resolved
manta-pay/src/crypto/ecc/arkworks.rs Outdated Show resolved Hide resolved
manta-pay/src/crypto/ecc/arkworks.rs Show resolved Hide resolved
@tsunrise tsunrise mentioned this pull request Mar 20, 2022
Closed
@bhgomes bhgomes mentioned this pull request Mar 21, 2022
Open
10 tasks
@tsunrise tsunrise requested a review from bhgomes March 22, 2022 04:30
bhgomes
bhgomes suggested changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@bhgomes bhgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more changes and we'll be good to go!

manta-pay/src/crypto/ecc/arkworks.rs Outdated Show resolved Hide resolved
manta-pay/src/crypto/ecc/arkworks.rs Outdated Show resolved Hide resolved
manta-pay/src/crypto/ecc/arkworks.rs Show resolved Hide resolved
manta-pay/src/crypto/ecc/arkworks.rs Show resolved Hide resolved
manta-pay/src/crypto/ecc/arkworks.rs Outdated Show resolved Hide resolved
manta-pay/src/crypto/ecc/arkworks.rs Outdated Show resolved Hide resolved
manta-pay/src/crypto/ecc/arkworks.rs Outdated Show resolved Hide resolved
manta-pay/src/crypto/ecc/arkworks.rs Outdated Show resolved Hide resolved
manta-pay/src/crypto/ecc/arkworks.rs Outdated Show resolved Hide resolved
manta-pay/src/crypto/ecc/arkworks.rs Outdated Show resolved Hide resolved
bhgomes
bhgomes suggested changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@bhgomes bhgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing about test naming.

manta-pay/src/crypto/ecc/arkworks.rs Outdated Show resolved Hide resolved
@tsunrise tsunrise requested a review from bhgomes March 25, 2022 05:04
bhgomes
bhgomes suggested changes Mar 25, 2022
View reviewed changes
manta-crypto/src/ecc.rs Outdated Show resolved Hide resolved
manta-pay/src/crypto/ecc/arkworks.rs Outdated Show resolved Hide resolved
manta-pay/src/crypto/ecc/arkworks.rs Outdated Show resolved Hide resolved
manta-pay/src/crypto/ecc/arkworks.rs Outdated Show resolved Hide resolved
manta-pay/src/crypto/ecc/arkworks.rs Outdated Show resolved Hide resolved
@bhgomes bhgomes merged commit a91d908 into main Mar 26, 2022
@bhgomes bhgomes deleted the scalar_mul_precomputed branch March 26, 2022 05:17
bhgomes added a commit that referenced this pull request Mar 26, 2022
@bhgomes
Revert "feat: support scalar mul of arkworks curve using precomputed …
d42cc04 
…table (#34)"

This reverts commit a91d908.
@tsunrise tsunrise mentioned this pull request Aug 8, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhgomes bhgomes bhgomes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Pre-computed Powers in Scalar Multiplication
2 participants
@tsunrise @bhgomes