Nullifier map optimization #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SupremoUGH
added
the
changelog:added
3 tasks
zqhxuyuan
approved these changes
May 24, 2023
ghzlatarev
reviewed
May 25, 2023
| nullifier: &Self::Nullifier, | ||
| decryption_key: &Self::DecryptionKey, | ||
| ) -> bool { | ||
| self.open(nullifier, decryption_key).is_some() |
There was a problem hiding this comment.
layman question: is there some way to check it can be opened without actually opening it ?
ghzlatarev
reviewed
May 25, 2023
| @@ -75,6 +78,16 @@ where | |||
| Extend::extend(self, items) | |||
| } | |||
|
|
|||
| #[inline] | |||
| fn remove(&mut self, item: &T) -> bool { | |||
There was a problem hiding this comment.
btw why was the vector impl needed ?
Seems we're mostly looking up and removing, so the hashset should be better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frees the signer memory from holding every nullifier. Now it only holds the user's nullifiers if they haven't been spent yet.
Goes together with Manta-Network/sdk#129
Before we can merge this PR, please make sure that all the following items have been checked off:
CHANGELOG.mdand added the appropriatechangeloglabel to the PR.Files changedin the GitHub PR explorer.CONTRIBUTING.md.