Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add sdk node example #139

Merged
merged 6 commits into from
Jul 12, 2023

Conversation

DanielZhangReal
Copy link
Contributor

@DanielZhangReal DanielZhangReal commented Jul 6, 2023

Add node.js version of SDK example


Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate L- label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.

@DanielZhangReal DanielZhangReal added L-added Changelog: add these changes to the `added` section of the changelog javascript Pull requests that update Javascript code labels Jul 6, 2023
@DanielZhangReal DanielZhangReal marked this pull request as ready for review July 6, 2023 05:52
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! But util.js probably would be useful for third party dev. They can't import it, maybe export it from sdk?

@DanielZhangReal
Copy link
Contributor Author

Sweet! But util.js probably would be useful for third party dev. They can't import it, maybe export it from sdk?

You are right. But this utils is only for the node side. Later, the monorepo of the SDK will be considered. At that time, these utils can be considered to be added to a separate node package.
I am still planning about monorepo, but there will be some plans in the near future.

@DanielZhangReal DanielZhangReal merged commit 93fb1c7 into signer_extension Jul 12, 2023
@DanielZhangReal DanielZhangReal deleted the feat/add-sdk-node-example branch July 12, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code L-added Changelog: add these changes to the `added` section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants