Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wallets deps #17

Merged
merged 2 commits into from
Apr 20, 2022
Merged

Fix wallets deps #17

merged 2 commits into from
Apr 20, 2022

Conversation

Kevingislason
Copy link
Contributor

Previous PR included local dependencies instead of git dependencies in manta-wasm-wallet

@Kevingislason Kevingislason requested a review from bhgomes April 18, 2022 03:46
Copy link
Contributor

@bhgomes bhgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You can also get rid of the .git at the end of the dependency URLs, it's not necessary.

@Kevingislason Kevingislason merged commit 4885951 into main Apr 20, 2022
@Kevingislason Kevingislason deleted the fix_wallets_deps branch April 20, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants