Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use old pull method #28

Merged
merged 3 commits into from
Jun 17, 2022
Merged

use old pull method #28

merged 3 commits into from
Jun 17, 2022

Conversation

Kevingislason
Copy link
Contributor

Changes manta-wasm-wallet-api to fetch on chain data using polkadot.js query methods rather than the new pull_ledger_diff rpc, which isn't ready yet

bhgomes
bhgomes previously approved these changes Jun 16, 2022
View reviewed changes
bhgomes
bhgomes previously approved these changes Jun 17, 2022
View reviewed changes
@Kevingislason Kevingislason requested a review from bhgomes June 17, 2022 19:10
@Kevingislason Kevingislason merged commit e248057 into main Jun 17, 2022
@Kevingislason Kevingislason deleted the fix/use_old_pull_method branch June 17, 2022 19:53
codecarrier1
codecarrier1 approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@codecarrier1 codecarrier1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codecarrier1 codecarrier1 codecarrier1 approved these changes

@bhgomes bhgomes bhgomes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kevingislason @bhgomes @codecarrier1