Pedro García ManyRequest Deliver #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phpunit.xml defines DB_DATABASE and cannot be overwritten by .env.testing which is a problem in cases like sqlite
Helps to prevent N+1 problem
…notification item
…tion/form components
…date form requests
…n clearing values
Now only the owner of the video can update or delete it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo page:
https://manyvideos.budare.dev
This pull request introduces several significant changes to the codebase, including updates to environment configuration, new controllers, and the addition of request validation classes. The most important changes are summarized below.
Environment Configuration Updates:
.env.example: ChangedAPP_NAMEfrom "Laravel" to "ManyVideos", switchedDB_CONNECTIONfromsqlitetomysql, and updated the broadcast connection to usepusher. Added newPUSHERconfiguration keys. [1] [2]Controller Additions:
app/Http/Controllers/CommentController.php: Added a newCommentControllerto handle CRUD operations for comments.app/Http/Controllers/HomeController.php: Added a newHomeControllerto handle the display of processed videos on the home page, with various filtering options.app/Http/Controllers/TagController.php: Added a newTagControllerto manage tags, including creating, updating, and deleting tags.app/Http/Controllers/VideoController.php: Added a newVideoControllerto handle video management, including processing, storing, and updating videos.Request Validation Classes:
app/Http/Requests/IndexHomeRequest.php: Added a new request validation class for handling home page filters.app/Http/Requests/StoreCommentRequest.php: Added a new request validation class for storing comments.app/Http/Requests/StoreTagRequest.php: Added a new request validation class for storing tags.app/Http/Requests/StoreVideoRequest.php: Added a new request validation class for storing videos.app/Http/Requests/UpdateCommentRequest.php: Added a new request validation class for updating comments.app/Http/Requests/UpdateTagRequest.php: Added a new request validation class for updating tags.app/Http/Requests/UpdateVideoRequest.php: Added a new request validation class for updating videos.Enum Addition:
app/Enums/VideoStatusEnum.php: Added a newVideoStatusEnumto manage video processing statuses.Jobs Addition:
Added the following jobs for Video Create and Update
ProcessVideoGenerateVideoThumbnailSaveVideoMetadataUpdateVideoStatusSendVideoProcessingCompletedNotificationMiddleware Update:
app/Http/Middleware/HandleInertiaRequests.php: Updated thesharemethod to includeuserUnreadNotifications.These changes collectively enhance the application's functionality for managing videos, comments, and tags, and improve the overall configuration and request handling.